-
Notifications
You must be signed in to change notification settings - Fork 291
adding a little more information to the workspace docs #1654
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! But there is one issue under "Managing Version Conflicts"
runtime/fundamentals/workspaces.md
Outdated
The workspace root's import map takes precedence over member-specific imports, | ||
which helps ensure consistent versions across your workspace. For example, if | ||
both the root and a member specify different versions of the same dependency, | ||
the root's version will be used. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's the opposite. It will use the member's version when resolving the dependency within the member's folder. The member allows overwriting it. That said, when resolving dependency's outside the member's folder, it will resolve based on the workspace root's folder.
Member deno.json dependencies are restricted to the specific member's folder, but the workspace root's deno.json applies to the entire application (including jsr and https dependencies)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Have updated to:
When resolving dependencies, workspace members can override dependencies defined
in the root. If both the root and a member specify different versions of the
same dependency, the member's version will be used when resolving within that
member's folder. This allows individual packages to use specific dependency
versions when needed.
However, member-specific dependencies are scoped only to that member's folder.
Outside of member folders, or when working with files at the workspace root
level, the workspace root's import map will be used for resolving dependencies
(including JSR and HTTPS dependencies).
No description provided.