8000 update mocking example after issue reported in #1631 by thisisjofrank · Pull Request #1662 · denoland/docs · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

update mocking example after issue reported in #1631 #1662

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
May 23, 2025
Merged

update mocking example after issue reported in #1631 #1662

merged 3 commits into from
May 23, 2025

Conversation

thisisjofrank
Copy link
Collaborator
@thisisjofrank thisisjofrank commented Apr 24, 2025 •
edited
Loading

fixes #1631

@thisisjofrank thisisjofrank marked this pull request as ready for review April 24, 2025 14:37
@thisisjofrank thisisjofrank changed the title update mocking example after issue reported in https://github.com/denoland/docs/issues/1631 update mocking example after issue reported in #1631 Apr 24, 2025
philhawksworth
philhawksworth approved these changes May 9, 2025
View reviewed changes
Copy link
Member
@philhawksworth philhawksworth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@thisisjofrank thisisjofrank merged commit 80258e0 into main May 23, 2025
4 checks passed
@thisisjofrank thisisjofrank deleted the mocking-update branch May 23, 2025 23:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@philhawksworth philhawksworth philhawksworth approved these changes

@marvinhagemeister marvinhagemeister Awaiting requested review from marvinhagemeister

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Bug: Basic mocking example doesn't work
2 participants
@thisisjofrank @philhawksworth
0