8000 0.40.8 breaks plugins loading · Issue #3202 · derailed/k9s · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

0.40.8 breaks plugins loading #3202

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
norman-zon opened this issue Mar 13, 2025 · 8 comments
Closed

0.40.8 breaks plugins loading #3202

norman-zon opened this issue Mar 13, 2025 · 8 comments
Labels
bug Something isn't working

Comments

@norman-zon
Copy link




Describe the bug
Updating 0.40.7 -> 0.40.8 breaks plugin loading, when using plugins spread over multiple files.

To Reproduce

  1. create plugin directory $XDG_DATA_DIRS/k9s/plugins/
  2. add file myplugins1.yaml
plugins:
  test1:
    shortCut: Shift-T
    scopes:
      - pods
    command: bash
    background: false
    args:
      - -c
      - "echo test1"

and myplugins2.yaml:

plugins:
  test2:
    shortCut: Shift-W
    scopes:
      - pods
    command: bash
    background: false
    args:
      - -c
      - "echo test2"
  test3:
    shortCut: Shift-Q
    scopes:
      - pods
    command: bash
    background: false
    args:
      - -c
      - "echo test3"

Historical Documents

Log:

9:35AM WRN Plugins load failed error="cannot parse /Users/xxx/.config/k9s/plugins/myplugins1.yaml into either a single plugin nor plugins: EOF"
9:35AM WRN Plugins load failed error="cannot parse /Users/xxx/.config/k9s/plugins/myplugins1.yaml into either a single plugin nor plugins: EOF"

Expected behavior
Plugins can be structured as before

Versions (please complete the following information):

  • OS: OSX 15
  • K9s: 0.40.7

Additional context
Add any other context about the problem here.
Until 0.40.7 the plugin structure worked. I suspect this change in internal/config/plugin.go to be the cause.
@derailed
Copy link
Owner

@norman-zon Plugins stored in the plugins dir unlike plugins.yaml have a different shape.
The yaml should not start a plugins: section.
Don't think v0.40.7 broke this feature?

@derailed derailed added as-designed Works as designed question Further information is requested labels Mar 14, 2025
@norman-zon
Copy link
Author
norman-zon commented Mar 14, 2025 •
edited
Loading

I tested with v0.40.7, which worked with nesting under plugins:, in v0.40.8 it doesn't work anymore.

But in v0.40.8 even removing the nesting like:

test1:
  shortCut: Shift-T
  scopes:
    - pods
  command: bash
  background: false
  args:
    - -c
    - "echo test1"

results in a failure to load the plugins. Really must be a regression.

@norman-zon norman-zon mentioned this issue Mar 14, 2025
Closed
@derailed derailed added bug Something isn't working and removed as-designed Works as designed question Further information is requested labels Mar 15, 2025
@derailed
Copy link
Owner

@norman-zon Doh! I stand corrected... Thank you! I've spaced that this was also a use case.

Going to take a closer look and give plugins some love. I am not super keen on the current implementation.
If you can, please take the next drop for a spin in case I've missed something... Tx!

@derailed derailed mentioned this issue Mar 15, 2025
Merged
@derailed
Copy link
Owner

Fixed v0.40.9

@danielrubin1989
Copy link
danielrubin1989 commented Mar 16, 2025 •
edited
Loading

@derailed After the upgrade to 0.40.9 I got the following errors:
error="open internal/config/json/schemas/plugin.json: no such file or directory
I tried both scenarios with plugins: and without

@svanharmelen
Copy link

I also don't get plugins anymore after updating to 0.40.9.

@derailed
Copy link
Owner
derailed commented Mar 16, 2025 •
edited
Loading

@danielrubin1989 But it works on my machine... Rats!!

8000

Thank for the heads up!
Hopefully we're happier on v0.40.10...

@derailed derailed mentioned this issue Mar 16, 2025
Merged
@danielrubin1989
Copy link

@derailed Thanks!! works for me on v0.40.10 👍

tmeijn pushed a commit to tmeijn/dotfiles that referenced this issue Mar 25, 2025
build(deps): update derailed/k9s to v0.40.10
dd7b063 
This MR contains the following updates:

| Package | Update | Change |
|---|---|---|
| [derailed/k9s](https://github.com/derailed/k9s) | patch | `v0.40.8` -> `v0.40.10` |

MR created with the help of [el-capitano/tools/renovate-bot](https://gitlab.com/el-capitano/tools/renovate-bot).

**Proposed changes to behavior should be submitted there as MRs.**

---

### Release Notes

<details>
<summary>derailed/k9s (derailed/k9s)</summary>

### [`v0.40.10`](https://github.com/derailed/k9s/releases/tag/v0.40.10)

[Compare Source](derailed/k9s@v0.40.9...v0.40.10)

<img src="https://raw.githubusercontent.com/derailed/k9s/master/assets/k9s.png" align="center" width="800" height="auto"/>

### Release v0.40.10
#### Notes

Thank you to all that contributed with flushing out issues and enhancements for K9s!
I'll try to mark some of these issues as fixed. But if you don't mind grab the latest rev
and see if we're happier with some of the fixes!
If you've filed an issue please help me verify and close.

Your support, kindness and awesome suggestions to make K9s better are, as ever, very much noted and appreciated!
Also big thanks to all that have allocated their own time to help others on both slack and on this repo!!

As you may know, K9s is not pimped out by corps with deep pockets, thus if you feel K9s is helping your Kubernetes journey,
please consider joining our [sponsorship program](https://github.com/sponsors/derailed) and/or make some noise on social! [@&#8203;kitesurfer](https://twitter.com/kitesurfer)

On Slack? Please join us [K9slackers](https://join.slack.com/t/k9sers/shared_invite/enQtOTA5MDEyNzI5MTU0LWQ1ZGI3MzliYzZhZWEyNzYxYzA3NjE0YTk1YmFmNzViZjIyNzhkZGI0MmJjYzhlNjdlMGJhYzE2ZGU1NjkyNTM)

#### Maintenance Release!

Sounds like I did hose plugins after all... With feelings!

-   Refactored plugins implementation, hopefully we didn't hose them 😳
-   Updated plugins docs
-   Apparently when it comes to icons, I've chosen... poorly 🙀
    Updated `write` icon 🔓->✍️, hopefully for the better 👀??

#### Videos Are In The Can!

Please dial [K9s Channel](https://www.youtube.com/channel/UC897uwPygni4QIjkPCpgjmw) for up coming content...

-   [K9s v0.40.0 -Column Blow- Sneak peek](https://youtu.be/iy6RDozAM4A)
-   [K9s v0.31.0 Configs+Sneak peek](https://youtu.be/X3444KfjguE)
-   [K9s v0.30.0 Sneak peek](https://youtu.be/mVBc1XneRJ4)
-   [Vulnerability Scans](https://youtu.be/ULkl0MsaidU)

***

#### Resolved Issues

-   [#&#8203;3202](derailed/k9s#3202) 0.40.8 breaks plugins loading

***

<img src="https://raw.githubusercontent.com/derailed/k9s/master/assets/imhotep_logo.png" width="32" height="auto"/> © 2025 Imhotep Software LLC. All materials licensed under [Apache v2.0](http://www.apache.org/licenses/LICENSE-2.0)

### [`v0.40.9`](https://github.com/derailed/k9s/releases/tag/v0.40.9)

[Compare Source](derailed/k9s@v0.40.8...v0.40.9)

<img src="https://raw.githubusercontent.com/derailed/k9s/master/assets/k9s.png" align="center" width="800" height="auto"/>

### Release v0.40.9
#### Notes

Thank you to all that contributed with flushing out issues and enhancements for K9s!
I'll try to mark some of these issues as fixed. But if you don't mind grab the latest rev
and see if we're happier with some of the fixes!
If you've filed an issue please help me verify and close.

Your support, kindness and awesome suggestions to make K9s better are, as ever, very much noted and appreciated!
Also big thanks to all that have allocated their own time to help others on both slack and on this repo!!

As you may know, K9s is not pimped out by corps with deep pockets, thus if you feel K9s is helping your Kubernetes journey,
please consider joining our [sponsorship program](https://github.com/sponsors/derailed) and/or make some noise on social! [@&#8203;kitesurfer](https://twitter.com/kitesurfer)

On Slack? Please join us [K9slackers](https://join.slack.com/t/k9sers/shared_invite/enQtOTA5MDEyNzI5MTU0LWQ1ZGI3MzliYzZhZWEyNzYxYzA3NjE0YTk1YmFmNzViZjIyNzhkZGI0MmJjYzhlNjdlMGJhYzE2ZGU1NjkyNTM)

#### Maintenance Release!

-   Refactored plugins implementation, hopefully we didn't hose them 😳
-   Updated plugins docs
-   Apparently when it comes to icons, I've chosen... poorly 🙀
    Updated `write` icon 🔓->✍️, hopefully for the better 👀??

#### Videos Are In The Can!

Please dial [K9s Channel](https://www.youtube.com/channel/UC897uwPygni4QIjkPCpgjmw) for up coming content...

-   [K9s v0.40.0 -Column Blow- Sneak peek](https://youtu.be/iy6RDozAM4A)
-   [K9s v0.31.0 Configs+Sneak peek](https://youtu.be/X3444KfjguE)
-   [K9s v0.30.0 Sneak peek](https://youtu.be/mVBc1XneRJ4)
-   [Vulnerability Scans](https://youtu.be/ULkl0MsaidU)

***

#### Resolved Issues

-   [#&#8203;3202](derailed/k9s#3202) 0.40.8 breaks plugins loading

***

<img src="https://raw.githubusercontent.com/derailed/k9s/master/assets/imhotep_logo.png" width="32" height="auto"/> © 2025 Imhotep Software LLC. All materials licensed under [Apache v2.0](http://www.apache.org/licenses/LICENSE-2.0)

</details>

---

### Configuration

📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined).

🚦 **Automerge**: Enabled.

♻ **Rebasing**: Whenever MR is behind base branch, or you tick the rebase/retry checkbox.

🔕 **Ignore**: Close this MR and you won't be reminded about this update again.

---

 - [ ] <!-- rebase-check -->If you want to rebase/retry this MR, check this box

---

This MR has been generated by [Renovate Bot](https://github.com/renovatebot/renovate).
<!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzOS4yMTIuMiIsInVwZGF0ZWRJblZlciI6IjM5LjIxMi4yIiwidGFyZ2V0QnJhbmNoIjoibWFpbiIsImxhYmVscyI6WyJSZW5vdmF0ZSBCb3QiXX0=-->
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: fix loading plugins from dir norman-zon/k9s
4 participants
@derailed @svanharmelen @danielrubin1989 @norman-zon
0