Multiplatform tasks should not depend on check #4025
Conversation
Codecov Report
@@ Coverage Diff @@
## main #4025 +/- ##
=========================================
Coverage 83.55% 83.55%
Complexity 3181 3181
=========================================
Files 459 459
Lines 9085 9085
Branches 1771 1771
=========================================
Hits 7591 7591
Misses 561 561
Partials 933 933 Continue to review full report at Codecov.
|
| it("detekt plain task will depend on check") { | ||
| gradleRunner.runTasksAndCheckResult(":check") { buildResult -> | ||
| assertThat(buildResult.tasks.map { it.path }).contains(":detekt") | ||
| } | ||
| } |
There was a problem hiding this comment.
| it("detekt plain task will depend on check") { | |
| gradleRunner.runTasksAndCheckResult(":check") { buildResult -> | |
| assertThat(buildResult.tasks.map { it.path }).contains(":detekt") | |
| } | |
| } |
I think this is already covered by https://github.com/detekt/detekt/pull/4025/files#diff-449c58285efdbf81c836b65ea85659877bfe46350c808afb25144183041de5f7R32
There was a problem hiding this comment.
already covered by #4025 (files)
Which file are you referring to? I moved this test inside DetektPlain as we want to verify this behavior only for the plain task
There was a problem hiding this comment.
😢 The link does not work properly. I intended to mention that this is already covered by line 32 in the same file. But now it seems that we could merge the two describe() spek together.
I don't think this is a blocking comment to be addressed though.
There was a problem hiding this comment.
Yup you're right, this test is unnecessary, as the one above is checking the same condition. I'm removing it.
5a2b629 to
29ee3d6
Compare
|
I assume that this PR fixes both linked issues, right? |
Nope it does not. It's related to both but the real fix needs to be discussed in the issues. |
This PR is cleaning up our task dependencies a bit. Specifically the only task that should be a dependency of
checkis the plaindetekttask.When I worked on the KMP implementation, I accidentally plugged all the KMP tasks to depend on
check. That's problematic as we still have some rough edges to fix and people might experience problems with their build because of this. See #3927 #3838