Prepare Detekt 1.20.0-RC1 #4597
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
#4588 was a PR rather than an issue. How would |
|
I guess I was asking about the automation (We need to manually close #4588 after merging this PR) |
BraisGabin
approved these changes
Feb 28, 2022
| - We've changed the behavior of the baseline task. Now the baseline is always update, even if you fixed all the issues in your codebase - [#4445](https://github.com/detekt/detekt/pull/4445) | ||
| - We now enable the naming ruleset by default also on tests. Previously they were excluded - [#4438](https://github.com/detekt/detekt/pull/4438) | ||
| - This version of Detekt is built with Gradle `v7.4`, AGP `7.1.1` and Kotlin `1.6.10` (see [#4530](https://github.com/detekt/detekt/pull/4530) [#4573](https://github.com/detekt/detekt/pull/4573) [#4133](https://github.com/detekt/detekt/pull/4133) [#4277](https://github.com/detekt/detekt/pull/4277)) | ||
| - This version of Detekt is wrapping KtLint version `0.43.2` (see [#4227](https://github.com/detekt/detekt/pull/4227)) |
There was a problem hiding this comment.
<3 thanks for write this detailed changelog.
Codecov Report
@@ Coverage Diff @@
## main #4597 +/- ##
===========================================
+ Coverage 0 84.56% +84.56%
- Complexity 0 3340 +3340
===========================================
Files 0 481 +481
Lines 0 11186 +11186
Branches 0 2038 +2038
===========================================
+ Hits 0 9459 +9459
- Misses 0 697 +697
- Partials 0 1030 +1030
Continue to review full report at Codecov.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Time to bake a new release of Detekt 🎉
@3flex I think we really need to switch over to having the composite build as default. Otherwise I essentially have to fix all the build failures of all the previous PRs. As an alternative, we can setup a CI job that runs a
publishToMavenLocaland runs tests against it.Closes #4588