detekt · 3flex · Jul 20, 2022 · Jul 20, 2022 · Jul 22, 2022 · Jul 29, 2022
diff --git a/build-logic/build.gradle.kts b/build-logic/build.gradle.kts
@@ -1,5 +1,6 @@
 plugins {
     `kotlin-dsl`
+    `java-gradle-plugin`
 }
 
 repositories {
@@ -13,3 +14,12 @@ dependencies {
     implementation(libs.semver4j.gradle)
     implementation(libs.nexusStaging.gradle)
 }
+
+gradlePlugin {
+    plugins {
+        create("injectedPlugin") {
+            id = "io.github.com.detekt.injected"
+            implementationClass = "InjectedDependenciesPlugin"
+        }
+    }
+}
diff --git a/build-logic/src/main/kotlin/InjectedDependenciesPlugin.kt b/build-logic/src/main/kotlin/InjectedDependenciesPlugin.kt
@@ -0,0 +1,46 @@
+import org.gradle.api.DefaultTask
+import org.gradle.api.Plugin
+import org.gradle.api.Project
+import org.gradle.api.file.ConfigurableFileCollection
+import org.gradle.api.file.DirectoryProperty
+import org.gradle.api.tasks.Classpath
+import org.gradle.api.tasks.Input
+import org.gradle.api.tasks.Nested
+import org.gradle.api.tasks.OutputDirectory
+import org.gradle.api.tasks.TaskAction
+import org.gradle.kotlin.dsl.domainObjectContainer
+
+class InjectedDependenciesPlugin : Plugin<Project> {
+    override fun apply(project: Project) {
+        project.tasks.register("generateClasspaths", GenerateClasspathsTask::class.java).configure {
+            targetDir.convention(project.layout.buildDirectory.dir("detektClasspathMetadata"))
+        }
+    }
+}
+
+interface InjectedDependencySet {
+    @get:Input
+    val name: String
+
+    @get:Classpath
+    val injectedClasspath: ConfigurableFileCollection
+}
+
+abstract class GenerateClasspathsTask : DefaultTask() {
+    @get:Nested
+    val injectedDependencies = project.objects.domainObjectContainer(InjectedDependencySet::class)
+
+    @get:OutputDirectory
+    abstract val targetDir: DirectoryProperty
+
+    @TaskAction
+    fun doStuff() {
+        val writeString = injectedDependencies.asMap.map {
+            val classpathString =
+                it.value.injectedClasspath.files.joinToString(java.io.File.pathSeparator) { it.invariantSeparatorsPath }
+            "${it.key}-classpath=$classpathString"
+        }
+        targetDir.get().asFile.mkdirs()
+        targetDir.file("detekt-classpath.properties").get().asFile.writeText(writeString.joinToString("\n"))
+    }
+}
diff --git a/detekt-gradle-plugin/build.gradle.kts b/detekt-gradle-plugin/build.gradle.kts
@@ -1,5 +1,6 @@
 plugins {
     id("module")
+    id("io.github.com.detekt.injected")
     `java-gradle-plugin`
     `java-test-fixtures`
     idea
@@ -56,6 +57,16 
10000
@@ testing {
 
 val pluginCompileOnly: Configuration by configurations.creating
 val functionalTestImplementation: Configuration by configurations.getting
+val functionalTestRuntimeOnly: Configuration by configurations.getting
+val smokeTest: Configuration by configurations.creating
+
+configurations.detekt {
+    resolutionStrategy.useGlobalDependencySubstitutionRules.set(false)
+}
+
+configurations.detektPlugins {
+    resolutionStrategy.useGlobalDependencySubstitutionRules.set(false)
+}
 
 configurations.compileOnly { extendsFrom(pluginCompileOnly) }
 
@@ -71,6 +82,10 @@ dependencies {
     // https://github.com/gradle/gradle/pull/19472
     functionalTestImplementation(testFixtures(project))
 
+    functionalTestRuntimeOnly(layout.files(tasks.generateClasspaths))
+
+    smokeTest("io.gitlab.arturbosch.detekt:detekt-cli")
+
     pluginCompileOnly(libs.android.gradle)
     pluginCompileOnly(libs.kotlin.gradle)
 
@@ -142,6 +157,18 @@ tasks {
     publishPlugins {
         notCompatibleWithConfigurationCache("https://github.com/gradle/gradle/issues/21283")
     }
+
+    generateClasspaths {
+        injectedDependencies {
+            create("implementation") {
+                injectedClasspath.from(smokeTest)
+            }
+        }
+    }
+
+    withType<Test>().configureEach {
+        inputs.files(generateClasspaths.get().targetDir)
+    }
 }
 
 // Skip publishing of test fixture API & runtime variants

diff --git a/detekt-gradle-plugin/settings.gradle.kts b/detekt-gradle-plugin/settings.gradle.kts
@@ -2,6 +2,8 @@ pluginManagement {
     includeBuild("../build-logic")
 }
 
+includeBuild("..")
+
 dependencyResolutionManagement {
     versionCatalogs {
         create("libs") {

diff --git a/...dle-plugin/src/functionalTest/kotlin/io/gitlab/arturbosch/detekt/DetektReportMergeSpec.kt b/...dle-plugin/src/functionalTest/kotlin/io/gitlab/arturbosch/detekt/DetektReportMergeSpec.kt
@@ -5,27 +5,37 @@ import io.gitlab.arturbosch.detekt.testkit.DslTestBuilder
 import io.gitlab.arturbosch.detekt.testkit.ProjectLayout
 import org.assertj.core.api.Assertions.assertThat
 import org.junit.jupiter.api.Test
+import java.io.File
+import java.util.Properties
 
 class DetektReportMergeSpec {
     @Test
     @Suppress("LongMethod")
     fun `Sarif merge is configured correctly for multi module project`() {
+        val propertiesUrl = Thread.currentThread().contextClassLoader.getResource("detekt-classpath.properties")
+        checkNotNull(propertiesUrl) { "Injected classpath file detekt-classpath.properties cannot be read" }
+        val properties = Properties()
+        propertiesUrl.openStream().use(properties::load)
+
+        val injectedDependencies = properties
+            .getProperty("implementation-classpath")
+            .split(File.pathSeparatorChar)
+            .joinToString(separator = "\", \"", prefix = "\"", postfix = "\"")
+
         val builder = DslTestBuilder.kotlin()
         val buildFileContent =
             """
             |${builder.gradlePlugins}
             |
-            |allprojects {
-            |  ${builder.gradleRepositories}
-            |}
-            |
             |val sarifReportMerge by tasks.registering(io.gitlab.arturbosch.detekt.report.ReportMergeTask::class) {
             |  output.set(project.layout.buildDirectory.file("reports/detekt/merge.sarif"))
             |}
             |
             |subprojects {
             |  ${builder.gradleSubprojectsApplyPlugins}
-            |  
+            |  dependencies {
+            |    detekt(files($injectedDependencies))
+            |  }
             |  detekt {
             |    reports.sarif.enabled = true
             |  }