8000 Add 'code_style' parameter to formatting rule set by 3flex · Pull Request #7959 · detekt/detekt · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Add 'code_style' parameter to formatting rule set #7959

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

Add 'code_style' parameter to formatting rule set #7959

wants to merge 3 commits into from

Conversation

3flex
Copy link
Member
@3flex 3flex commented Feb 18, 2025

Fixes #5991

This is a notable change as anyone using the android config parameter now needs to set code_style: android_studio.

@detekt-ci
Copy link
Collaborator
detekt-ci commented Feb 18, 2025 •
edited
Loading
Warnings
⚠️ It looks like this PR contains functional changes without a corresponding test.

Generated by 🚫 dangerJS against a3278c7

@codecov Codecov
Copy link
codecov bot commented Feb 18, 2025 •
edited
Loading

Codecov Report

Attention: Patch coverage is 60.00000% with 2 lines in your changes missing coverage. Please review.

Project coverage is 85.43%. Comparing base (11df356) to head (a3278c7).
Report is 145 commits behind head on main.

Files with missing lines Patch % Lines
...lab/arturbosch/detekt/formatting/FormattingRule.kt 50.00% 0 Missing and 2 partials ⚠️

❌ Your patch check has failed because the patch coverage (60.00%) is below the target coverage (80.00%). You can increase the patch coverage or adjust the target coverage.

Additional details and impacted files 
@@             Coverage Diff              @@
##               main    #7959      +/-   ##
============================================
- Coverage     85.44%   85.43%   -0.01%     
+ Complexity     4223     4221       -2     
============================================
  Files           573      573              
  Lines         13301    13301              
  Branches       2544     2544              
============================================
- Hits          11365    11364       -1     
  Misses          659      659              
- Partials       1277     1278       +1

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

3flex
3flex commented Feb 18, 2025
View reviewed changes
@3flex 3flex added the notable changes Marker for notable changes in the changelog label Feb 18, 2025
@cortinico cortinico added this to the 2.0.0 milestone Feb 18, 2025
cortinico
cortinico approved these changes Feb 19, 2025
View reviewed changes
Copy link
Member
@cortinico cortinico left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1 to this. We'll need to update the docs for this as well though

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@BraisGabin BraisGabin BraisGabin approved these changes

@cortinico cortinico cortinico approved these changes

Assignees
No one assigned
Labels
formatting notable changes Marker for notable changes in the changelog
Projects
None yet
Milestone
2.0.0
Development

Successfully merging this pull request may close these issues.

Support ktlint code styles
4 participants
@3flex @detekt-ci @BraisGabin @cortinico
0