8000 MagicNumber rule: don't check Character, Boolean and null by t-kameyama · Pull Request #3064 · detekt/detekt · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

MagicNumber rule: don't check Character, Boolean and null #3064

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Sep 11, 2020
Merged

MagicNumber rule: don't check Character, Boolean and null #3064

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions detekt-rules-style/src/main/kotlin/io/gitlab/arturbosch/detekt/rules/style/MagicNumber.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,6 +11,7 @@ import io.gitlab.arturbosch.detekt.api.internal.valueOrDefaultCommaSeparated
import io.gitlab.arturbosch.detekt.rules.isConstant
import io.gitlab.arturbosch.detekt.rules.isHashCodeFunction
import io.gitlab.arturbosch.detekt.rules.isPartOf
import org.jetbrains.kotlin.KtNodeTypes
import org.jetbrains.kotlin.com.intellij.psi.PsiElement
import org.jetbrains.kotlin.lexer.KtTokens
import org.jetbrains.kotlin.psi.KtAnnotationEntry
Expand Down Expand Up @@ -108,7 +109,11 @@ class MagicNumber(config: Config = Config.empty) : Rule(config) {
valueOrDefault(IGNORE_COMPANION_OBJECT_PROPERTY_DECLARATION, true)
private val ignoreRanges = valueOrDefault(IGNORE_RANGES, false)

@Suppress("ReturnCount")
override fun visitConstantExpression(expression: KtConstantExpression) {
val elementType = expression.elementType
if (elementType != KtNodeTypes.INTEGER_CONSTANT && elementType != KtNodeTypes.FLOAT_CONSTANT) return

if (isIgnoredByConfig(expression) || expression.isPartOfFunctionReturnConstant() ||
expression.isPartOfConstructorOrFunctionConstant()) {
return
Expand Down
0