8000 Update github actions to use nodejs16 by thepetk · Pull Request #181 · devfile/registry-support · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Update github actions to use nodejs16 #181

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Aug 24, 2023
Merged

Update github actions to use nodejs16 #181

merged 1 commit into from
Aug 24, 2023

Conversation

thepetk
Copy link
Contributor
@thepetk thepetk commented Aug 23, 2023 •
edited
Loading

Please specify the area for this PR

/area registry

What does does this PR do / why we need it:

This PR updates specific deprecated github actions in order to ensure that we are not using NodeJS 12 anymore to our GH Actions. More info here

The Github Actions updated are:

  • actions/checkout@v2 > actions/checkout@c85c95e3d7251135ab7dc9ce3241c5835cc595a9 # v3.5.3
  • actions/setup-go@v2 > actions/setup-go@93397bea11091df50f3d7e59dc26a7711a8bcfbe # v4.1.0
  • codecov/codecov-action@v2.1.0 > codecov/codecov-action@eaaf4bedf32dbdc6b720b63067d99c4d77d6047d # v3.1.4
  • docker/login-action@v1 > docker/login-action@465a07811f14bebb1938fbed4728c6a1ff8901fc # v2.2.0

Which issue(s) this PR fixes:

Fixes devfile/api#1226

PR acceptance criteria:

  • Test Coverage
    • Are your changes sufficiently tested, and are any applicable test cases added or updated to cover your changes?

Documentation (WIP)

How to test changes / Special notes to the reviewer:

The updates have been tested here: https://github.com/thepetk/devfile-registry-support/actions
Note that the actions might failed for the fork but the actions are running correctly

@thepetk thepetk self-assigned this Aug 23, 2023
@openshift-ci
Copy link
openshift-ci bot commented Aug 23, 2023

@thepetk: The label(s) area/registry cannot be applied, because the repository doesn't have them.

In response to this:

Please specify the area for this PR

/area registry

What does does this PR do / why we need it:

This PR updates specific deprecated github actions in order to ensure that we are not using NodeJS 12 anymore to our GH Actions. More info here

The Github Actions updated are:

  • actions/checkout@v2 > actions/checkout@c85c95e3d7251135ab7dc9ce3241c5835cc595a9 # v3.5.3
  • actions/setup-go@v2 > actions/setup-go@93397bea11091df50f3d7e59dc26a7711a8bcfbe # v4.1.0
  • codecov/codecov-action@v2.1.0 > codecov/codecov-action@eaaf4bedf32dbdc6b720b63067d99c4d77d6047d # v3.1.4
  • docker/login-action@v1 > docker/login-action@465a07811f14bebb1938fbed4728c6a1ff8901fc # v2.2.0

Which issue(s) this PR fixes:

Fixes devfile/api#1226

PR acceptance criteria:

  • Test Coverage
    • Are your changes sufficiently tested, and are any applicable test cases added or updated to cover your changes?

Documentation (WIP)

How to test changes / Special notes to the reviewer:

The updates have been tested here: https://github.com/thepetk/devfile-registry-support/actions
Note that the actions might failed for the fork but the actions are running correctly

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci openshift-ci bot requested a review from maysunfaisal August 23, 2023 15:21
@thepetk thepetk mentioned this pull request Aug 23, 2023
Closed
@thepetk thepetk closed this Aug 23, 2023
@thepetk thepetk reopened this Aug 23, 2023
@codecov
Copy link
codecov bot commented Aug 23, 2023 •
edited
Loading

Codecov Report

Patch and project coverage have no change.

Comparison is base (b136d19) 35.93% compared to head (cb38a5f) 35.93%.

Additional details and impacted files 
@@           Coverage Diff           @@
##             main     #181   +/-   ##
=======================================
  Coverage   35.93%   35.93%           
=======================================
  Files           7        7           
  Lines        1347     1347           
=======================================
  Hits          484      484           
  Misses        816      816           
  Partials       47       47

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@thepetk
Feature/update gh actions (#4)
cb38a5f 
* Update gh actions for nodejs16

Signed-off-by: thepetk <thepetk@gmail.com>

* Further updates on gh actions versions

Signe-off-by: thepetk <thepetk@gmail.com>
Signed-off-by: thepetk <thepetk@gmail.com>

---------

Signed-off-by: thepetk <thepetk@gmail.com>
kim-tsao
kim-tsao approved these changes Aug 23, 2023
View reviewed changes
@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Aug 23, 2023
@openshift-ci
Copy link
openshift-ci bot commented Aug 23, 2023

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: kim-tsao, thepetk
Once this PR has been reviewed and has the lgtm label, please assign johnmcollier for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accep 8000 ted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@thepetk thepetk merged commit a807358 into devfile:main Aug 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kim-tsao kim-tsao kim-tsao approved these changes

@johnmcollier johnmcollier Awaiting requested review from johnmcollier

@michael-valdron michael-valdron Awaiting requested review from michael-valdron

@maysunfaisal maysunfaisal Awaiting requested review from maysunfaisal

Assignees

@thepetk thepetk

@kim-tsao kim-tsao

Labels
lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Update deprecated Node.js 12 actions in the Registry-Support repo
2 participants
@thepetk @kim-tsao
0