8000 new icon: pandas (plain, plain-wordmark, original, original-wordmark) by EnisMulic · Pull Request #422 · devicons/devicon · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

new icon: pandas (plain, plain-wordmark, original, original-wordmark) #422

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 4 commits into from
Closed

new icon: pandas (plain, plain-wordmark, original, original-wordmark) #422

wants to merge 4 commits into from

Conversation

EnisMulic
Copy link
Contributor
@EnisMulic EnisMulic commented Jan 2, 2021 •
edited
Loading

Taken from #170

@Thomas-Boi Thomas-Boi added the bot:peek Use this label to trigger peek-bot. Remove and re-add the label to re-trigger label Jan 5, 2021
amacado
amacado requested changes Jan 5, 2021
View reviewed changes
Copy link
Member
@amacado amacado left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Which project does this icon refers to? Is it https://pandas.pydata.org/? Then the icon which is provided in this pull request is outdated. Maybe you have a idea and are able to enlighten me?

Also the font rendering does not went well (missing squares around the graphs)

screenshot_0
screenshot_1

@amacado amacado added feature:icon Use this label for pull requests when a new icon is ready to be added to the collection discussion Use this label for community discussions about changes/features/.. labels Jan 5, 2021
@EnisMulic
Copy link
Contributor Author

I found the logo in PR #170 . But it seems like pandas got a new logo a year ago. Feel free to reject this PR and I'll open a new issue for pandas

@amacado
Copy link
Member
amacado commented Jan 5, 2021

I will close this since the icon is outdated.

@amacado amacado closed this Jan 5, 2021
@EnisMulic EnisMulic deleted the ReallyLiri/feature/icon/pandas branch January 5, 2021 21:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@amacado amacado amacado requested changes

Assignees

@EnisMulic EnisMulic

Labels
bot:peek Use this label to trigger peek-bot. Remove and re-add the label to re-trigger discussion Use this label for community discussions about changes/features/.. feature:icon Use this label for pull requests when a new icon is ready to be added to the collection
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@EnisMulic @amacado @Thomas-Boi
0