new icon: fsharp (original,plain) #495
Conversation
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
There was a problem hiding this comment.
Hello @maltejur! Thanks for contributing F#. The icon looks great, but to fulfill our guidelines:
The plain and line versions (with or without wordmark) need to stay as simple as possible. They must have only one color and the paths are united. We will strip the color when turning it into icons so they can have any color.
I would like to ask you to add a plain version of the icon to use it as font. You can simple remove the color from the original icon and save it as fsharp-plain.svg. So we can use it in the font. This ensures each font icon has at least a plain or line version (naming convention).
|
Hi! Everything looks great. Good job! Have a nice day, |
|
Sure
That line confused me a little bit, I thought this was an automated process, but now I also added a plain icon. |
|
Hi there, I'm Devicons' Peek Bot and I just peeked at the icons that you wanted to add using icomoon.io. 
There was a problem hiding this comment.
That line confused me a little bit, I thought this was an automated process, but now I also added a plain icon.
Yeah, sorry. I understand that this can be confusing.. Currently our bot does not support to fix this by itself and reupload the result back to the repo. We are working on this.. :)
Anyway: fsharp icons looking great! Thanks for adding them to our project @maltejur. They will be included in our next release! :)
* new icon: fsharp (original) * new icon: fsharp (plain)
I added a icon for F Sharp. Just the original version, because it is simple enough (I hope I wrote the devicon.json the right way for that, first PR here so I am still learning how it works).