feat: Setup Stale workflow #524
Conversation
|
Hey @Panquesito7, What is the Probot Stale app? Based on what I've seen, it leaves a comment on PRs/Issues that are stale right? For Devicon, we unfortunately accumulate a lot of stale issues. These are features/bugs that we haven't have time to get around fixing but we will do it eventually. I'm debating whether we need this bot since our use case is very specific. Same for the PR as well. A few of them need to be split up into smaller PRs which will be done once we get around to it. |
After 30 days (or a specific period of time), it will mark a PR/issue as stale. It will post a comment (customizable) saying that the PR/issue is stale/abandoned now. I copied the message you send on a stale PR. I think this will be useful for PRs that have been there a long time opened. The PR/issue won't be closed automatically unless specified. Let's see what @amacado thinks about this. 🙂 |
|
Hello! My first thought was: "Great idea", but when I think about it longer, I follow the thought of @Thomas-Boi. In my opinion we would have to distinguish between Pull-Requests and Issues. For pull requests a I don't see an option in the https://github.com/marketplace/stale bot to distingush between pull requests and issues, so this might not be the best fit for our project. |
|
It would be nice if we could apply this only for PRs... Tell me what do you think. 🙂 |
This action seems better suited for us. I'm down for us using this one 👍 |
ca392c7 to
4bb713d
Compare
There was a problem hiding this comment.
I think it would be a good idea to have a note in our https://github.com/devicons/devicon/blob/master/CONTRIBUTING.md guidelines to inform about this action and what it does?
There was a problem hiding this comment.
Hey @Panquesito7 ,
This PR looks good. I think you only need to update the README.md and everything should be good to go.
01b86b1 to
ded0713
Compare
Co-authored-by: Clemens Bastian <amacado@users.noreply.github.com>
If there are errors in the workflow syntax, it would display an error. For example, see this run (it has been already fixed). |
Co-authored-by: Clemens Bastian <amacado@users.noreply.github.com>
* feat: Setup Stale workflow * Change stale pull request message Thanks, @Thomas-Boi! * Add a note on `README.md` about stale PRs * Fix some issues with the workflow * Apply suggestions from code review Co-authored-by: Clemens Bastian <amacado@users.noreply.github.com> * Apply suggestions from code review Co-authored-by: Clemens Bastian <amacado@users.noreply.github.com> Co-authored-by: Clemens Bastian <amacado@users.noreply.github.com>
Things added/changed: