8000 new icon: subversion (original, original-wordmark) by MichielPater · Pull Request #731 · devicons/devicon · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

new icon: subversion (original, original-wordmark) #731

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 9 commits into from
Jul 13, 2021
Merged

new icon: subversion (original, original-wordmark) #731

merged 9 commits into from
Jul 13, 2021

Conversation

MichielPater
Copy link
Contributor

And re-sorted icons starting with 's' alphabetically

@MichielPater
new icon: subversion (original, original-wordmark)
a38a9a4 
- re-sorted icons starting with 's' alphabetically
@Panquesito7 Panquesito7 added the feature:icon Use this label for pull requests when a new icon is ready to be added to the collection label Jul 7, 2021
@github-actions
Copy link
Contributor
github-actions bot commented Jul 7, 2021

Hi!

I'm Devicons' SVG-Checker Bot and it seems we have some issues with your SVGs.

Here is what went wrong:

icons/subversion/subversion-original-wordmark.svg:
-'viewBox' is not '0 0 128 128' -> Set it or scale the file using https://www.iloveimg.com/resize-image/resize-svg

icons/subversion/subversion-original.svg:
-'viewBox' is not '0 0 128 128' -> Set it or scale the file using https://www.iloveimg.com/resize-image/resize-svg

For more reference on why these are errors, check out our CONTRIBUTING guide

Please address these issues. When you update this PR, I will check your SVGs again.

Thanks for your help,
SVG-Checker Bot 😄

PS. One day, I will be smart enough to fix these errors for you 😣. Until then, I can only point them out.

Panquesito7
Panquesito7 previously requested changes Jul 7, 2021
View reviewed changes
MichielPater and others added 4 commits July 7, 2021 21:41
@MichielPater @Panquesito7
Update devicon.json
4328c0b 
Added wordmark to subversion

Co-authored-by: David Leal <halfpacho@gmail.com>
@MichielPater @Panquesito7
Update devicon.json
e747976 
Added aliases to subversion

Co-authored-by: David Leal <halfpacho@gmail.com>
@MichielPater @Panquesito7
Update icons/subversion/subversion-original-wordmark.svg
b56b78d 
Added viewbox to subversion

Co-authored-by: David Leal <halfpacho@gmail.com>
@MichielPater @Panquesito7
Update icons/subversion/subversion-original.svg
1b72564 
Added viewport to subversion

Co-authored-by: David Leal <halfpacho@gmail.com>
@Thomas-Boi Thomas-Boi added the bot:peek Use this label to trigger peek-bot. Remove and re-add the label to re-trigger label Jul 9, 2021
@github-actions
Copy link
Contributor
github-actions bot commented Jul 9, 2021

Hi there,

I'm Devicons' Peek Bot and it seems we've ran into a problem.

Expecting ',' delimiter: line 3566 column 13 (char 75110)

Make sure that:

  • Your svgs are named and added correctly to the /icons folder as seen here.
  • Your icon information has been added to the devicon.json as seen here
  • Your PR title follows the format seen here

I will retry once everything is fixed. If I still fail or there are other error, the maintainers will investigate.

Best of luck,
Peek Bot ☺️

@MichielPater @Thomas-Boi
Update devicon.json (fix)
711b749 
Co-authored-by: Thomas Bui <43018778+Thomas-Boi@users.noreply.github.com>
@Thomas-Boi Thomas-Boi added bot:peek Use this label to trigger peek-bot. Remove and re-add the label to re-trigger and removed bot:peek Use this label to trigger peek-bot. Remove and re-add the label to re-trigger labels Jul 9, 2021
@github-actions
Copy link
Contributor
github-actions bot commented Jul 9, 2021

Hi there,

I'm Devicons' Peek Bot and I just peeked at the icons that you wanted to add using icomoon.io.
Here is the result below (top left):

Imgur Images

Here are the zoomed-in screenshots of the added icons:
Imgur Images

Note: If the images don't show up, it's probably because it has been autodeleted by Imgur after 6 months due to our API choice.

The maintainers will now take a look at it and decide whether to merge your PR.

Thank you for contributing to Devicon! I hope everything works out and your icons are accepted into the repo.

Cheers,
Peek Bot 😊

@Thomas-Boi Thomas-Boi added bot:peek Use this label to trigger peek-bot. Remove and re-add the label to re-trigger and removed bot:peek Use this label to trigger peek-bot. Remove and re-add the label to re-trigger labels Jul 9, 2021
@github-actions
Copy link
Contributor
github-actions bot commented Jul 9, 2021

Hi there,

I'm Devicons' Peek Bot and I just peeked at the icons that you wanted to add using icomoon.io.
Here is the result below (top left):

Imgur Images

Here are the zoomed-in screenshots of the added icons:
Imgur Images

Note: If the images don't show up, it's probably because it has been autodeleted by Imgur after 6 months due to our API choice.

The maintainers will now take a look at it and decide whether to merge your PR.

Thank you for contributing to Devicon! I hope everything works out and your icons are accepted into the repo.

Cheers,
Peek Bot 😊

Thomas-Boi
Thomas-Boi reviewed Jul 9, 2021
View reviewed changes
MichielPater and others added 2 commits July 13, 2021 14:23
@MichielPater @Thomas-Boi
Update devicon.json
a3b9a31 
Co-authored-by: Thomas Bui <43018778+Thomas-Boi@users.noreply.github.com>
@Thomas-Boi
Merge branch 'develop' into add-subversion
88e5b32
@Thomas-Boi Thomas-Boi dismissed Panquesito7’s stale review July 13, 2021 17:14

This has been resolved

@Thomas-Boi Thomas-Boi added bot:peek Use this label to trigger peek-bot. Remove and re-add the label to re-trigger and removed bot:peek Use this label to trigger peek-bot. Remove and re-add the label to re-trigger labels Jul 13, 2021
@github-actions
Copy link
Contributor

Hi there,

I'm Devicons' Peek Bot and I just peeked at the icons that you wanted to add using icomoon.io.
Here is the result below (top left):

Imgur Images

Here are the zoomed-in screenshots of the added icons:
Imgur ImagesImgur Images

Note: If the images don't show up, it's probably because it has been autodeleted by Imgur after 6 months due to our API choice.

The maintainers will now take a look at it and decide whether to merge your PR.

Thank you for contributing to Devicon! I hope everything works out and your icons are accepted into the repo.

Cheers,
Peek Bot 😊

Thomas-Boi
Thomas-Boi reviewed Jul 13, 2021
View reviewed changes
Copy link
Member
@Thomas-Boi Thomas-Boi left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I was wrong about the wordmark version being icon friendly. I'll remove it from the devicon.json for you.

@Thomas-Boi Thomas-Boi added bot:peek Use this label to trigger peek-bot. Remove and re-add the label to re-trigger and removed bot:peek Use this label to trigger peek-bot. Remove and re-add the label to re-trigger labels Jul 13, 2021
@github-actions
Copy link
Contributor

Hi there,

I'm Devicons' Peek Bot and I just peeked at the icons that you wanted to add using icomoon.io.
Here is the result below (top left):

Imgur Images

Here are the zoomed-in screenshots of the added icons:
Imgur Images

Note: If the images don't show up, it's probably because it has been autodeleted by Imgur after 6 months due to our API choice.

The maintainers will now take a look at it and decide whether to merge your PR.

Thank you for contributing to Devicon! I hope everything works out and your icons are accepted into the repo.

Cheers,
Peek Bot 😊

Thomas-Boi
Thomas-Boi approved these changes Jul 13, 2021
View reviewed changes
Copy link
Member
@Thomas-Boi Thomas-Boi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The icon is great now. Thank you for your work @MichielPater. Looking forward to your other PRs.

@Thomas-Boi Thomas-Boi merged commit 4fa0b0f into devicons:develop Jul 13, 2021
@Thomas-Boi Thomas-Boi mentioned this pull request Aug 14, 2021
Merged
@amacado amacado mentioned this pull request Aug 14, 2021
Merged
GCHQDeveloper926 pushed a commit to GCHQDeveloper926/devicon that referenced this pull request Dec 20, 2024
@MichielPater @Panquesito7 @Thomas-Boi
new icon: subversion (original, original-wordmark) (devicons#731)
8cfca6f 
* new icon: subversion (original, original-wordmark)
- re-sorted icons starting with 's' alphabetically

* Update devicon.json

Added wordmark to subversion

Co-authored-by: David Leal <halfpacho@gmail.com>

* Update devicon.json

Added aliases to subversion

Co-authored-by: David Leal <halfpacho@gmail.com>

* Update icons/subversion/subversion-original-wordmark.svg

Added viewbox to subversion

Co-authored-by: David Leal <halfpacho@gmail.com>

* Update icons/subversion/subversion-original.svg

Added viewport to subversion

Co-authored-by: David Leal <halfpacho@gmail.com>

* Update devicon.json (fix)

Co-authored-by: Thomas Bui <43018778+Thomas-Boi@users.noreply.github.com>

* Update devicon.json

Co-authored-by: Thomas Bui <43018778+Thomas-Boi@users.noreply.github.com>

* Apply suggestions from code review

Co-authored-by: David Leal <halfpacho@gmail.com>
Co-authored-by: Thomas Bui <43018778+Thomas-Boi@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Thomas-Boi Thomas-Boi Thomas-Boi approved these changes

@Panquesito7 Panquesito7 Panquesito7 left review comments

Assignees
No one assigned
Labels
bot:peek Use this label to trigger peek-bot. Remove and re-add the label to re-trigger feature:icon Use this label for pull requests when a new icon is ready to be added to the collection
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@MichielPater @Thomas-Boi @Panquesito7
0