10000 new icon: windows11 (original, original-wordmark, plain, plain-wordmark) by Panquesito7 · Pull Request #822 · devicons/devicon · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

new icon: windows11 (original, original-wordmark, plain, plain-wordmark) #822

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 4 commits into from
Closed

new icon: windows11 (original, original-wordmark, plain, plain-wordmark) #822

wants to merge 4 commits into from

Conversation

Panquesito7
Copy link
Member

New icon section

Double check these details before you open a PR

  • PR does not match another non-stale PR currently opened
  • PR name matches the format new icon: Icon name (versions separated by comma). More details here
  • The PR's base is the develop branch.
  • Your icons are inside a folder as seen here
  • SVG matches the standards laid out here
  • A new object is added in the devicon.json file as seen here

Link to prove your SVG is correct and up-to-date

https://www.microsoft.com/es-mx/windows/windows-11

@Panquesito7 Panquesito7 added the feature:icon Use this label for pull requests when a new icon is ready to be added to the collection label Aug 23, 2021
@Panquesito7 Panquesito7 requested a review from Thomas-Boi August 23, 2021 18:02
@Panquesito7 Panquesito7 linked an issue Aug 23, 2021 that may be closed by this pull request
Icon request: Windows 11 #800
Closed
@Panquesito7 Panquesito7 added the bot:peek Use this label to trigger peek-bot. Remove and re-add the label to re-trigger label Aug 23, 2021
@Panquesito7 Panquesito7 changed the title new icon: windows11 (original, original-wordmark) new icon: windows11 (original, original-wordmark, plain, plain-wordmark) Aug 23, 2021
@devicons devicons deleted a comment from github-actions bot Aug 23, 2021
@devicons devicons deleted a comment from github-actions bot Aug 23, 2021
@devicons devicons deleted a comment from github-actions bot Aug 23, 2021
@Panquesito7 Panquesito7 force-pushed the panquesito7/new_icon/windows11 branch from 5827330 to 0a95ac6 Compare August 23, 2021 18:30
@Panquesito7 Panquesito7 added bot:peek Use this label to trigger peek-bot. Remove and re-add the label to re-trigger and removed bot:peek Use this label to trigger peek-bot. Remove and re-add the label to re-trigger labels Aug 23, 2021
@github-actions
Copy link
Contributor

Hi there,

I'm Devicons' Peek Bot and it seems we've ran into a problem.

Message: No connection could be made because the target machine actively refused it. (os error 10061)

Make sure that:

  • Your svgs are named and added correctly to the /icons folder as seen here.
  • Your icon information has been added to the devicon.json as seen here
  • Your PR title follows the format seen here

I will retry once everything is fixed. If I still fail or there are other error, the maintainers will investigate.

Best of luck,
Peek Bot ☺️

@devicons devicons deleted a comment from github-actions bot Aug 23, 2021
@devicons devicons deleted a comment from github-actions bot Aug 23, 2021
@devicons devicons deleted a comment from github-actions bot Aug 23, 2021
@Thomas-Boi Thomas-Boi added bot:peek Use this label to trigger peek-bot. Remove and re-add the label to re-trigger and removed bot:peek Use this label to trigger peek-bot. Remove and re-add the label to re-trigger labels Aug 23, 2021
@github-actions

This comment has been minimized.

Sign in to view
1 similar comment
@github-actions

This comment has been minimized.

Sign in to view
@Thomas-Boi
Copy link
Member

Never seen that bug before in my life.

@Thomas-Boi Thomas-Boi added bot:peek Use this label to trigger peek-bot. Remove and re-add the label to re-trigger and removed bot:peek Use this label to trigger peek-bot. Remove and re-add the label to re-trigger labels Aug 23, 2021
@github-actions
Copy link
Contributor

Hi there,

I'm Devicons' Peek Bot and it seems we've ran into a problem.

Message: [Exception... "Failure"  nsresult: "0x80004005 (NS_ERROR_FAILURE)"  location: "JS frame :: chrome://remote/content/marionette/capture.js :: capture.canvas :: line 141"  data: no]

Make sure that:

  • Your svgs are named and added correctly to the /icons folder as seen here.
  • Your icon information has been added to the devicon.json as seen here
  • Your PR title follows the format seen here

I will retry once everything is fixed. If I still fail or there are other error, the maintainers will investigate.

Best of luck,
Peek Bot ☺️

@Thomas-Boi
Copy link
Member

@Panquesito7 I look around for what's causing your errors and I'm not sure what's happening. There are similar errors caused by firefox's screenshot functions but apparently it had been fixed 3 years ago. I'll try updating the geckodriver and see if it fixes the issues.

@Thomas-Boi
Copy link
Member

Hey @Panquesito7,

Please close this PR and reopen a new one into my fork's develop branch. I've added the geckodriver updates to it and now I'm testing whether that fixes the issues.

@Thomas-Boi Thomas-Boi closed this Aug 24, 2021
@Panquesito7
Copy link
Member Author

I'll do that, thanks. 🙂

@Panquesito7 Panquesito7 reopened this Aug 24, 2021
@Panquesito7 Panquesito7 reopened this Aug 27, 2021
@Panquesito7 Panquesito7 added bot:peek Use this label to trigger peek-bot. Remove and re-add the label to re-trigger and removed bot:peek Use this label to trigger peek-bot. Remove and re-add the label to re-trigger labels Aug 27, 2021
@github-actions
Copy link
Contributor

Hi there,

I'm Devicons' Peek Bot and it seems we've ran into a problem.

Message: No connection could be made because the target machine actively refused it. (os error 10061)

Make sure that:

  • Your svgs are named and added correctly to the /icons folder as seen here.
  • Your icon information has been added to the devicon.json as seen here
  • Your PR title follows the format seen here

I will retry once everything is fixed. If I still fail or there are other error, the maintainers will investigate.

Best of luck,
Peek Bot ☺️

This was referenced Aug 29, 2021
Closed
Merged
@Thomas-Boi Thomas-Boi reopened this Sep 9, 2021
@Thomas-Boi Thomas-Boi added bot:peek Use this label to trigger peek-bot. Remove and re-add the label to re-trigger and removed bot:peek Use this label to trigger peek-bot. Remove and re-add the label to re-trigger labels Sep 9, 2021
@github-actions
Copy link
Contributor
github-actions bot commented Sep 9, 2021

Hi there,

I'm Devicons' Peek Bot and I just peeked at the icons that you wanted to add using icomoon.io.

WARNING -- Strokes detected in the following SVGs:

  • windows11-original-wordmark.svg

Here are the SVGs as intepreted by Icomoon when we upload the files:
Imgur Images

Here are the zoomed-in screenshots of the added icons as SVGs. This is how Icomoon intepret the uploaded SVGs:
Imgur Images Imgur Images

Here are the icons that will be generated by Icomoon:
Imgur Images

Here are the zoomed-in screenshots of the added icons as icons. This is what the font will look like:
Imgur Images Imgur Images

You can click on the pictures and zoom on them if needed.

The maintainers will now check for:

  1. The number of Glyphs matches the number of SVGs that were selected.
  2. The icons (second group of pictures) look the same as the SVGs (first group of pictures).
  3. The icons are of high quality (legible, matches the official logo, etc.)

In case of font issues, it might be caused by Icomoon not accepting strokes in the SVGs. Check this doc for more details and fix the issues as instructed by Icomoon and update this PR once you are done.

Thank you for contributing to Devicon! I hope that your icons are accepted into the repository.

Note: If the images don't show up, it's probably because it has been autodeleted by Imgur after 6 months due to our API choice.

Cheers,
Peek Bot 😊

@Thomas-Boi
Copy link
Member

Hi @Panquesito7,

The icon looks pretty good to me. However, the text is a bit big. What do you think?

@Thomas-Boi
Copy link
Member

Seems like your SVG has an img in it:
image

It'd be best if you can change that to a normal text then convert it into paths

@Thomas-Boi
Copy link
Member

Hey @Panquesito7, are you still working on this? If not, I'll close this PR so someone else can do this icon.

@Panquesito7
Copy link
Member Author

Hey @Panquesito7, are you still working on this? If not, I'll close this PR so someone else can do this icon.

Sure, feel free to close it.

@Thomas-Boi Thomas-Boi closed this Oct 22, 2021
@Thomas-Boi Thomas-Boi deleted the panquesito7/new_icon/windows11 branch December 22, 2021 06:10
@PantheraRed PantheraRed mentioned this pull request Jan 9, 2023
Merged
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Thomas-Boi Thomas-Boi Awaiting requested review from Thomas-Boi

Assignees
No one assigned
Labels
bot:peek Use this label to trigger peek-bot. Remove and re-add the label to re-trigger feature:icon Use this label for pull requests when a new icon is ready to be added to the collection
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Icon request: Windows 11
2 participants
@Panquesito7 @Thomas-Boi
0