8000 new icon: v8 (original, plain) by ngdream · Pull Request #1354 · devicons/devicon · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

new icon: v8 (original, plain) #1354

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 37 commits into from
Nov 10, 2022
Merged

new icon: v8 (original, plain) #1354

merged 37 commits into from
Nov 10, 2022

Conversation

ngdream
Copy link
Contributor
@ngdream ngdream commented Aug 19, 2022 •
edited by Snailedlt
Loading

add icon for google v8 engine

This PR closes #1352

@Panquesito7 Panquesito7 added the feature:icon Use this label for pull requests when a new icon is ready to be added to the collection label Aug 20, 2022
@github-actions
Copy link
Contributor

Hi!

I'm the check-bot and we have some issues with your PR:

Error found in 'devicon.json' for 'v8' entry: 
- missing key: 'aliases'.

SVG Error in 'v8-original.svg':
- 'viewBox' is not '0 0 128 128' -> Set it or scale the file using https://www.iloveimg.com/resize-image/resize-svg.

Check our CONTRIBUTING guide for more details regarding these errors.

Please address these issues. When you update this PR, I will check your SVGs again.

Thanks for your help,
SVG-Checker Bot 😄

@Snailedlt
Copy link
Collaborator

@ngdream could you try and fix the issues found by check-bot above?
Altnames is also missing from devicon.json

@ngdream
Copy link
Contributor Author
ngdream commented Aug 20, 2022

@ngdream could you try and fix the issues found by check-bot above? Altnames is also missing from devicon.json

thanks

christ118
christ118 previously approved these changes Aug 20, 2022
View reviewed changes
@Snailedlt Snailedlt added the bot:peek Use this label to trigger peek-bot. Remove and re-add the label to re-trigger label Aug 21, 2022
@github-actions
Copy link
Contributor

Hi there,

I'm Devicons' Peek Bot and it seems we've ran into a problem.

This path doesn't exist: 'D:\a\devicon\devicon\icons\v8\v8-plain.svg'

Make sure that:

    < 8000 li>Your svgs are named and added correctly to the /icons folder as seen here.
  • Your icon information has been added to the devicon.json as seen here
  • Your PR title follows the format seen here

I will retry once everything is fixed. If I still fail or there are other error, the maintainers will investigate.

Best of luck,
Peek Bot ☺️

Snailedlt
Snailedlt requested changes Aug 21, 2022
View reviewed changes
@Snailedlt Snailedlt added bot:peek Use this label to trigger peek-bot. Remove and re-add the label to re-trigger and removed bot:peek Use this label to trigger peek-bot. Remove and re-add the label to re-trigger labels Aug 21, 2022
@github-actions

This comment was marked as outdated.

Sign in to view
@Snailedlt
Copy link
Collaborator

@ngdream the icon doesn't look right when uploaded as a font to icomoon. Are there any icons you could upload that are unicolored?

ngdream
ngdream commented Aug 22, 2022
View reviewed changes
Copy link
Contributor Author
@ngdream ngdream left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thank

Panquesito7
Panquesito7 reviewed Aug 23, 2022
View reviewed changes
@ngdream @Panquesito7
Update icons/v8/v8-original.svg
59c23a2 
Co-authored-by: David Leal <halfpacho@gmail.com>
@Panquesito7 Panquesito7 added bot:peek Use this label to trigger peek-bot. Remove and re-add the label to re-trigger and removed bot:peek Use this label to trigger peek-bot. Remove and re-add the label to re-trigger labels Aug 23, 2022
@Panquesito7 Panquesito7 requested a review from Snailedlt August 23, 2022 21:14
@github-actions

This comment was marked as outdated.

Sign in to view
@ngdream ngdream requested review from Snailedlt and removed request for Snailedlt November 4, 2022 22:21
@ngdream
Copy link
Contributor Author
ngdream commented Nov 5, 2022

let's merge now 😢

@Snailedlt Snailedlt changed the title new icon: v8 (original) new icon: v8 (original,plain) Nov 7, 2022
@Snailedlt Snailedlt added bot:peek Use this label to trigger peek-bot. Remove and re-add the label to re-trigger and removed bot:peek Use this label to trigger peek-bot. Remove and re-add the label to re-trigger stale For PRs that haven't had any activity for a while and old issues labels Nov 7, 2022
@github-actions
Copy link
Contributor
github-actions bot commented Nov 7, 2022

Hi there,

I'm Devicons' Peek Bot and I just peeked at the icons that you wanted to add using icomoon.io.

Here are the SVGs as intepreted by Icomoon when we upload the files:
Imgur Images

Here are the zoomed-in screenshots of the added icons as SVGs:
Imgur Images

Here are the icons that will be generated by Icomoon:
Imgur Images

Here are the zoomed-in screenshots of the added icons as icons:
Imgur Images

Here are the colored versions:
Imgur Images

The maintainers will now check for:

  1. The number of Glyphs matches the number of SVGs that were selected.
  2. The icons (second group of pictures) look the same as the SVGs (first group of pictures).
  3. The icons are of high quality (legible, matches the official logo, etc.)

In case of font issues, it might be caused by Icomoon not accepting strokes in the SVGs. Check this doc for more details and fix the issues as instructed by Icomoon and update this PR once you are done.

Thank you for contributing to Devicon! I hope that your icons are accepted into the repository.

Note: If the images don't show up, it has been autodeleted by Imgur after 6 months due to our API choice.

Cheers,
Peek Bot 😊

Snailedlt
Snailedlt reviewed Nov 7, 2022
View reviewed changes
@Snailedlt Snailedlt added bot:peek Use this label to trigger peek-bot. Remove and re-add the label to re-trigger and removed bot:peek Use this label to trigger peek-bot. Remove and re-add the label to re-trigger labels Nov 7, 2022
@github-actions
Copy link
Contributor
github-actions bot commented Nov 7, 2022

Hi there,

I'm Devicons' Peek Bot and I just peeked at the icons that you wanted to add using icomoon.io.

Here are the SVGs as intepreted by Icomoon when we upload the files:
Imgur Images

Here are the zoomed-in screenshots of the added icons as SVGs:
Imgur Images

Here are the icons that will be generated by Icomoon:
Imgur Images

Here are the zoomed-in screenshots of the added icons as icons:
Imgur Images

Here are the colored versions:
Imgur Images

The maintainers will now check for:

  1. The number of Glyphs matches the number of SVGs that were selected.
  2. The icons (second group of pictures) look the same as the SVGs (first group of pictures).
  3. The icons are of high quality (legible, matches the official logo, etc.)

In case of font issues, it might be caused by Icomoon not accepting strokes in the SVGs. Check this doc for more details and fix the issues as instructed by Icomoon and update this PR once you are done.

Thank you for contributing to Devicon! I hope that your icons are accepted into the repository.

Note: If the images don't show up, it has been autodeleted by Imgur after 6 months due to our A 8000 PI choice.

Cheers,
Peek Bot 😊

Snailedlt
Snailedlt previously approved these changes Nov 7, 2022
View reviewed changes
Copy link
Collaborator
@Snailedlt Snailedlt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Made a small commit to get this through, hope that's okey with you @ngdream :)

LGTM ✔️
Thank you for your contributions! 💯

lunatic-fox
lunatic-fox previously approved these changes Nov 8, 2022
View reviewed changes
Copy link
Contributor
@lunatic-fox lunatic-fox left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I made a tiny change to align the devicon.json. Hope that's ok @ngdream.
Approved! ✔
Thank you for contributing! 🚀

@lunatic-fox
Update devicon.json
b585931 
Fixing alignment of line 7979.
@Snailedlt Snailedlt requested a review from lunatic-fox November 8, 2022 07:20
@Snailedlt
Copy link
9E88 Collaborator

@Panquesito7 This is ready for merging now if you agree. Your review is currently blocking the merge

Panquesito7
Panquesito7 approved these changes Nov 10, 2022
View reviewed changes
Copy link
Member
@Panquesito7 Panquesito7 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! 🚀

@Panquesito7 Panquesito7 merged commit 5eb17a7 into devicons:develop Nov 10, 2022
@Panquesito7 Panquesito7 changed the title new icon: v8 (original,plain) new icon: v8 (original, plain) Nov 10, 2022
@Snailedlt Snailedlt mentioned this pull request Feb 5, 2024
Merged
GCHQDeveloper926 pushed a commit to GCHQDeveloper926/devicon that referenced this pull request Dec 20, 2024
@ngdream @Snailedlt
@Panquesito7 @lunatic-fox
new icon: v8 (original, plain) (devicons#1354)
28b4ba7 
* Create v8-original.svg

* Update devicon.json

* Update devicon.json

* Update v8-original.svg

* Update devicon.json

* add altnames

* Update devicon.json

* Update icons/v8/v8-original.svg

Co-authored-by: David Leal <halfpacho@gmail.com>

* Update devicon.json

* Create wxwidget-original.svg

* Delete wxwidget-original.svg

* Update devicon.json

* Update devicon.json

* Create wxwidget-original.svg

* Delete wxwidget-original.svg

* Update devicon.json

* Update devicon.json

Co-authored-by: David Leal <halfpacho@gmail.com>

* Update devicon.json

good

Co-authored-by: David Leal <halfpacho@gmail.com>

* Change to official v8 logo
Change to the official logo from v8's website: https://v8.dev/logo

* Add files via upload

* Update icons/v8/v8-plain.svg

Co-authored-by: Jørgen Kalsnes Hagen <43886029+Snailedlt@users.noreply.github.com>

* Update devicon.json

* Update devicon.json

* Add aliases to wordmark versions

* remove empty line

* Update devicon.json

* Update devicon.json

* Update devicon.json

* Update devicon.json

Co-authored-by: Josélio Júnior <76992016+lunatic-fox@users.noreply.github.com>

* Update devicon.json

Co-authored-by: Josélio Júnior <76992016+lunatic-fox@users.noreply.github.com>

* Update devicon.json

Co-authored-by: Josélio Júnior <76992016+lunatic-fox@users.noreply.github.com>

* Change font from original to plain

* Update devicon.json

Fixing alignment of line 7979.

Co-authored-by: Jørgen Kalsnes Hagen <43886029+Snailedlt@users.noreply.github.com>
Co-authored-by: David Leal <halfpacho@gmail.com>
Co-authored-by: Josélio Júnior <76992016+lunatic-fox@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Snailedlt Snailedlt Snailedlt approved these changes

@Panquesito7 Panquesito7 Panquesito7 approved these changes

@lunatic-fox lunatic-fox lunatic-fox approved these changes

@christ118 christ118 christ118 left review comments

Assignees
No one assigned
Labels
bot:peek Use this label to trigger peek-bot. Remove and re-add the label to re-trigger feature:icon Use this label for pull requests when a new icon is ready to be added to the collection
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@ngdream @Snailedlt @Panquesito7 @kilianpaquier @lunatic-fox @christ118
0