8000 Icons: Karma, Jest, Nest, CircleCI, Codecov by rjlopezdev · Pull Request #166 · devicons/devicon · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Icons: Karma, Jest, Nest, CircleCI, Codecov #166

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 5 commits into from
Closed

Icons: Karma, Jest, Nest, CircleCI, Codecov #166

wants to merge 5 commits into from

Conversation

rjlopezdev
Copy link
Contributor

Description

This PR add modern platform/framework icons:

@amacado amacado added the feature:icon Use this label for pull requests when a new icon is ready to be added to the collection label Jun 8, 2020
This was linked to issues Jun 8, 2020
Icon request: Jest #210
Closed
Icon Request: Frontend Tools #183
Closed
[feat/icon]: circleci #98
Closed
amacado
amacado requested changes Jun 11, 2020
View reviewed changes
Copy link
Member
@amacado amacado left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for your contribution. Please take a look at our updated contribution guidelines and pay special attention to:

  • Create a separated pull request for each icon (no matter how many variations)
  • Modify devicon-colors.css to include the colored version of the icon

@jerdog
Copy link
jerdog commented Aug 14, 2020

As an employee of CircleCI what can I do to assist with getting this over the line?

@amacado
Copy link
Member
amacado commented Aug 14, 2020

Hello @jerdog! I'm happy to hear someone picks up this old pull request. To allow us a structured review, please see our contributing guildelines.

  • Create a separated pull request for each icon (no matter how many variations)
  • Include the name of the icon in the pull request f.e. "new icon: html5 (original, plain, line)"
  • At least the plain or line version of the icon is required (since those are required for the icon font)
  • Modify devicon.json to include the icon (or variations)
  • Modify devicon-colors.css to include the colored version of the icon
  • optional: Add a image of the new icon(s) to the description of the pull request
  • optional: Reference the issues regarding the new icon

Organizational guidelines

  • Each icon has his own folder located in the "icons" folder
  • Each icon folder contains one .eps file and as many .svg files as versions available
  • The .eps file contains all available versions of an icon. Each version is contained in a 128px by 128px artboard
  • Each .svg file contains one version of an icon in a "0 0 128 128" viewbox
  • The naming convention for the svg file is the following: (icon name)-(original/plain/line)-(wordmark)

@Thomas-Boi
Copy link
Member

Hello there,
Recently, we just introduced an automation pipeline to Devicon which will help us create the icons. Before we can merge your changes in, there are a few things that we need to do first:

  1. Merge the current devicon/develop branch into your PR branch. This contains the build script needed for us to build your icons.
  2. Read the CONTRIBUTING.md for things to do before merging and review our icon standards.
  3. Push your changes and/or branches. We will review them once this is done and merge your PR if everything goes well.

Thank you for contributing to this repo. We are sorry that we haven't accept any PR for awhile. Now that we have a build pipeline, we can merge PRs more quickly than before.

We hope to see your icons in the Devicon repo soon :)

Cheers,
Devicon Team

@Thomas-Boi
Copy link
Member

Hello there,

We notice that this PR has been inactive for awhile now. It would be a waste of your time and effort if we just close this PR and throw away the SVGs in here. Thus, 1 month from now, if this PR remains inactive/stale, we will fork your repo, fix any issues, and merge your icons ourselves.

Since GitHub tracks contributions by commits, you will still be credited. We also hope that you will help us merge this PR before the deadline comes.

Cheers,
Devicon Team

@Thomas-Boi Thomas-Boi added the stale For PRs that haven't had any activity for a while and old issues label Jan 6, 2021
@Thomas-Boi
Copy link
Member

Hi @rjlopezdev, would you like to continue working on this or should I take over? I can also guide you with our new commit policy as well.

This was referenced May 27, 2021
Merged
Merged
Merged
@Thomas-Boi
Copy link
Member

Hello @rjlopezdev, sorry for the long wait. We have split up your PR into smaller PRs listed above. All of them are good except for NestJS. Unfortunately, we already accept a PR with that icon.

Nonetheless, great job! We will soon merge your icons into the repo. @jerdog CircleCI will be in soon as well

@Thomas-Boi Thomas-Boi closed this May 27, 2021
@Thomas-Boi Thomas-Boi mentioned this pull request May 27, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@amacado amacado amacado requested changes

@perjerz perjerz perjerz approved these changes

Assignees

@rjlopezdev rjlopezdev

Labels
feature:icon Use this label for pull requests when a new icon is ready to be added to the collection stale For PRs that haven't had any activity for a while and old issues
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Icon request: Jest Icon Request: Frontend Tools [feat/icon]: circleci
5 participants
@rjlopezdev @jerdog @amacado @Thomas-Boi @perjerz
0