new icon: kdeneon (original,plain) #1777
Conversation
There was a problem hiding this comment.
- Optimize SVG code. Use SVGOMG.
- Remove
heightandwidthand replace byviewBox.
There was a problem hiding this comment.
There also seem to be merge conflicts.
Please fix those. If you need any help, let us know. 🙂
There was a problem hiding this comment.
Hello there! 👋🏼
Since you based this pull request on your master branch dotarjun:master, I recommend you to do another pull request but based on your develop branch.
Here goes some git commands to help on this procedure:
git checkout develop # Go to "develop" branch.
git merge upstream/develop develop # Update your "develop" branch with "devicons:develop".
git push origin # Push the update to your remote "develop" branch.
git branch add_kdeneon # Create a "add_kdeneon" branch.
git checkout add_kdeneon # Go to "add_kdeneon" branch.
git checkout master icons/kdeneon # From your current "master" branch pick up just the icons.Now that you're still on add_kdeneon branch open devicon.json and add your entry, between karma: line 4917 and keras: line 4918 entries:
{
"name": "kdeneon",
"altnames": [],
"tags": [
"linux",
"operating system",
"open-source"
],
"versions": {
"svg": [
"original",
"plain"
],
"font": [
"plain"
]
},
"color": "#21769a",
"aliases": []
},Once done just publish (commit) this new branch and make the pull request again. 🙂
After that you can close this pull request too. 👍🏼
You can also reset the changes you made on your master branch by the last commit 1119b9f84c0290e0f0b38982099a2bd027a48bf1:
git reset --hard 1119b9f84c0290e0f0b38982099a2bd027a48bf1
git push -f origin💡 Remember in future contributions to always base your branches on your develop branch.
Wish for the best! 🚀
Double check these details before you open a PR
developbranch.devicon.jsonfile as seen hereThis PR closes NONE
#1754
Link to prove your SVG is correct and up-to-date.
https://en.wikipedia.org/wiki/KDE_neon