8000 update icon: unity (original, original-wordmark, plain, plain-wordmark, line, line-wordmark) by Snailedlt · Pull Request #1994 · devicons/devicon · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

update icon: unity (original, original-wordmark, plain, plain-wordmark, line, line-wordmark) #1994

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Nov 12, 2023
Merged

update icon: unity (original, original-wordmark, plain, plain-wordmark, line, line-wordmark) #1994

merged 4 commits into from
Nov 12, 2023

Conversation

Snailedlt
Copy link
Collaborator
@Snailedlt Snailedlt commented Nov 12, 2023 •
edited
Loading

Double check these details before you open a PR

  • PR does not match another non-stale PR currently opened
  • PR name matches the format new icon: Icon name (versions separated by comma). More details here
  • PR's base is the develop branch.
  • Your icons are inside a folder as seen here
  • SVG matches the standards laid out here
  • A new object is added in the devicon.json file as seen here

This PR closes NONE

fixes issues with #1977

Link to prove your SVG is correct and up-to-date.

line-wordmark version was recreated using the made-with-unity logo: https://brandfolder.com/s/3v2rb9wqbr9sjbh5gqmmcq
all other versions are modifications of the existing versions in the develop branch.

@Snailedlt Snailedlt changed the base branch from master to develop November 12, 2023 14:20
@Snailedlt Snailedlt changed the title Fix artifacts with unity icons update icon: (original, original-wordmark, plain, plain-wordmark, line, line-wordmark) Nov 12, 2023
@Snailedlt Snailedlt requested a review from canaleal November 12, 2023 14:20
@Snailedlt Snailedlt closed this Nov 12, 2023
@Snailedlt Snailedlt reopened this Nov 12, 2023
@Snailedlt Snailedlt mentioned this pull request Nov 12, 2023
Closed
@Snailedlt
Copy link
Collaborator Author

Previews:
image
image
image
image
image

@Snailedlt Snailedlt changed the title update icon: (original, original-wordmark, plain, plain-wordmark, line, line-wordmark) update icon: unity (original, original-wordmark, plain, plain-wordmark, line, line-wordmark) Nov 12, 2023
@Snailedlt Snailedlt closed this Nov 12, 2023
@Snailedlt Snailedlt reopened this Nov 12, 2023
@Snailedlt Snailedlt added the feature:icon Use this label for pull requests when a new icon is ready to be added to the collection label Nov 12, 2023
lunatic-fox
lunatic-fox approved these changes Nov 12, 2023
View reviewed changes
Copy link
Contributor
@lunatic-fox lunatic-fox left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great one! 💯
Made a tiny adjustment on each icon by removing some unnecessary whitespace characters. 🔧
Thank you for this contribution! 🚀

mahmudunnabikajal
mahmudunnabikajal approved these changes Nov 12, 2023
View reviewed changes
8000
Copy link
@mahmudunnabikajal mahmudunnabikajal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Icon looks good!

canaleal
canaleal approved these changes Nov 12, 2023
View reviewed changes
Copy link
Member
@canaleal canaleal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice. All is good.

@lunatic-fox lunatic-fox merged commit e46a27f into devicons:develop Nov 12, 2023
@Snailedlt Snailedlt mentioned this pull request Feb 5, 2024
Merged
GCHQDeveloper926 pushed a commit to GCHQDeveloper926/devicon that referenced this pull request Dec 20, 2024
@Snailedlt @lunatic-fox
update icon: unity (original, original-wordmark, plain, plain-wordmar…
10bc5d3 
…k, line, line-wordmark) (devicons#1994)

* fix artifacts for line versions

* resize all versions to fit viewbox

* Remove unnecessary whitespaces

---------

Co-authored-by: Josélio Júnior <76992016+lunatic-fox@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@canaleal canaleal canaleal approved these changes

@mahmudunnabikajal mahmudunnabikajal mahmudunnabikajal approved these changes

@lunatic-fox lunatic-fox lunatic-fox approved these changes

Assignees
No one assigned
Labels
feature:icon Use this label for pull requests when a new icon is ready to be added to the collection
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@Snailedlt @canaleal @mahmudunnabikajal @lunatic-fox
0