8000 new icon: nuxt (original, original-wordmark, plain-wordmark) by typed-sigterm · Pull Request #2173 · devicons/devicon · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

new icon: nuxt (original, original-wordmark, plain-wordmark) #2173

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 12 commits into from
Jun 15, 2025
Merged

new icon: nuxt (original, original-wordmark, plain-wordmark) #2173

merged 12 commits into from
Jun 15, 2025

Conversation

typed-sigterm
Copy link

close #2172

@AnshSinghSonkhia
Copy link

Hey @Zihan-Hu,
you have to work on the SVGs.
Refer: Resize the SVG and Align Horizontally/ Vertically (Inkscape)

And, also Unify the Paths as mentioned in the above tutorial

@typed-sigterm
Copy link
Author

Hey @Zihan-Hu, you have to work on the SVGs. Refer: Resize the SVG and Align Horizontally/ Vertically (Inkscape)

And, also Unify the Paths as mentioned in the above tutorial

Thank you! I've done it in a80996e

@Snailedlt Snailedlt added the feature:icon PR when a new icon is ready to be added to the collection label Jul 1, 2024
@Snailedlt Snailedlt requested review from a team, ConX, weh, Snailedlt, canaleal and lunatic-fox and removed request for a team July 1, 2024 06:54
@canaleal
Copy link
Member

@typed-sigterm Sorry, but this MR needs to be on its on branch. The changes made are directly in the develop branch.

@Snailedlt
Copy link
Collaborator

@canaleal it should be fine since it's on the develop branch of his own fork :)
Only maintianers are able to edit the develop branch directly

@canaleal canaleal changed the title update icon: nuxtjs (original, original-wordmark, plain, plain-wordmark) update icon: nuxtjs (original, original-wordmark) Mar 16, 2025
canaleal
canaleal previously requested changes Mar 16, 2025
View reviewed changes
canaleal
canaleal reviewed Mar 16, 2025
View reviewed changes
canaleal
canaleal reviewed Mar 16, 2025
View reviewed changes
@typed-sigterm typed-sigterm changed the title update icon: nuxtjs (original, original-wordmark) new icon: nuxt (original, original-wordmark, plain-wordmark) Mar 16, 2025
@typed-sigterm
Copy link
Author
typed-sigterm commented Mar 16, 2025 •
edited
Loading

@canaleal Thank you for the guidance ❤️

According to the official statement of Nuxt Team, nuxtjs is a former name, now it's formally nuxt. So I kept the old design of nuxtjs and added the new design as nuxt.

@typed-sigterm typed-sigterm requested a review from canaleal March 16, 2025 07:32
@canaleal
Copy link
Member
canaleal commented Jun 1, 2025

@typed-sigterm Sorry, but can the merge conflicts be resolved.

@Snailedlt Snailedlt added the bot:peek Trigger peek-bot. Remove and re-add the label to re-trigger label Jun 2, 2025
@github-actions GitHub Actions
Copy link
Contributor
github-actions bot commented Jun 2, 2025

Hi there,

I'm Devicons' Peek Bot and it seems we've ran into a problem.

This path doesn't exist: '/home/runner/work/devicon/devicon/icons/nuxt/nuxt-plain.svg'

Make sure that:

  • Your SVGs are named and added correctly to the /icons folder as seen here.
  • Your icon information has been added to the devicon.json as seen here
  • Your PR title follows the format seen here

I will retry once everything is fixed. If I still fail or there are other error, the maintainers will investigate.

Best of luck,
Peek Bot ☺️

@github-actions GitHub Actions
Copy link
Contributor
github-actions bot commented Jun 2, 2025

Hi!

I'm the check-bot and we have some issues with your PR:

devicon.json is not sorted correctly.
Please make sure that your icon is added in the `devicon.json` file at the correct alphabetic position
as seen here: https://github.com/devicons/devicon/wiki/Updating-%60devicon.json%60



Error found regarding filenames:
- This path doesn't exist: '/home/runner/work/devicon/devicon/icons/nuxt/nuxt-plain.svg'

Error checking SVGs: no SVGs to check. Might be caused by above issues.

Check our CONTRIBUTING guide for more details regarding these errors.

Please address these issues. When you update this PR, I will check your SVGs again.

Thanks for your help,
SVG-Checker Bot 😄

Snailedlt
Snailedlt requested changes Jun 2, 2025
View reviewed changes
@github-actions GitHub Actions
Copy link
Contributor
github-actions bot commented Jun 2, 2025

Hi!

I'm the check-bot and we have some issues with your PR:

devicon.json is not sorted correctly.
Please make sure that your icon is added in the `devicon.json` file at the correct alphabetic position
as seen here: https://github.com/devicons/devicon/wiki/Updating-%60devicon.json%60



Error found regarding filenames:
- This path doesn't exist: '/home/runner/work/devicon/devicon/icons/nuxt/nuxt-plain.svg'

Error checking SVGs: no SVGs to check. Might be caused by above issues.

Check our CONTRIBUTING guide for more details regarding these errors.

Please address these issues. When you update this PR, I will check your SVGs again.

Thanks for your help,
SVG-Checker Bot 😄

Snailedlt
Snailedlt reviewed Jun 2, 2025
View reviewed changes
Snailedlt
Snailedlt reviewed Jun 2, 2025
View reviewed changes
Snailedlt
Snailedlt reviewed Jun 2, 2025
View reviewed changes
Snailedlt
Snailedlt reviewed Jun 2, 2025
View reviewed changes
Copy link
Collaborator
@Snailedlt Snailedlt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I fixed some minor stuff:

  • fixed the color
  • added alias for plain icon and removed "plain" from svg and font attributes

@Snailedlt Snailedlt added bot:peek Trigger peek-bot. Remove and re-add the label to re-trigger and removed bot:peek Trigger peek-bot. Remove and re-add the label to re-trigger labels Jun 2, 2025
@github-actions GitHub Actions
Copy link
Contributor
github-actions bot commented Jun 2, 2025

Hi!

I'm the check-bot and we have some issues with your PR:

devicon.json is not sorted correctly.
Please make sure that your icon is added in the `devicon.json` file at the correct alphabetic position
as seen here: https://github.com/devicons/devicon/wiki/Updating-%60devicon.json%60

Check our CONTRIBUTING guide for more details regarding these errors.

Please address these issues. When you update this PR, I will check your SVGs again.

Thanks for your help,
SVG-Checker Bot 😄

@github-actions GitHub Actions
Copy link
Contributor
github-actions bot commented Jun 2, 2025

Hi there,

I'm Devicons' Peek Bot and I just peeked at the icons that you wanted to add using icomoon.io.

Here are the SVGs as intepreted by Icomoon when we upload the files:
Imgur Images

Here are the zoomed-in screenshots of the added icons as SVGs:
Imgur Images Imgur Images

Here are the icons that will be generated by Icomoon:
Imgur Images

Here are the zoomed-in screenshots of the added icons as icons:
Imgur Images Imgur Images

Here are the colored versions:
Imgur Images Imgur Images

The maintainers will now check for:

  1. The number of Glyphs matches the number of SVGs that were selected.
  2. The icons (second group of pictures) look the same as the SVGs (first group of pictures).
  3. The icons are of high quality (legible, matches the official logo, etc.)
  4. A new object is added in the devicon.json file at the correct alphabetic position as seen here

In case of font issues, it might be caused by Icomoon not accepting strokes in the SVGs. Check this doc for more details and fix the issues as instructed by Icomoon and update this PR once you are done.

Thank you for contributing to Devicon! I hope that your icons are accepted into the repository.

Note: If the images don't show up, it has been autodeleted by Imgur after 6 months due to our API choice.

Cheers,
Peek Bot 😊

Snailedlt
Snailedlt approved these changes Jun 2, 2025
View reviewed changes
Copy link
Collaborator
@Snailedlt Snailedlt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! ✔️
Thank you for the contribution! 🙇

@Snailedlt Snailedlt requested review from canaleal and removed request for canaleal June 2, 2025 12:53
@Snailedlt
Copy link
Collaborator

@canaleal please re-review this when you have time :)

weh
weh approved these changes Jun 10, 2025
View reviewed changes
Copy link
Contributor
@weh weh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good 👍

@canaleal canaleal dismissed their stale review June 15, 2025 04:27

Resolved

@canaleal canaleal merged commit 73fa860 into devicons:develop Jun 15, 2025
5 checks passed
@typed-sigterm typed-sigterm deleted the develop branch June 15, 2025 06:56
@canaleal canaleal mentioned this pull request Jun 30, 2025
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@weh weh weh approved these changes

@swapnilhpatil swapnilhpatil swapnilhpatil approved these changes

@Snailedlt Snailedlt Snailedlt approved these changes

@ConX ConX Awaiting requested review from ConX ConX was automatically assigned from devicons/devicon__reviewers

@lunatic-fox lunatic-fox Awaiting requested review from lunatic-fox lunatic-fox was automatically assigned from devicons/devicon__reviewers

@canaleal canaleal Awaiting requested review from canaleal

Assignees
No one assigned
Labels
bot:peek Trigger peek-bot. Remove and re-add the label to re-trigger feature:icon PR when a new icon is ready to be added to the collection
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@typed-sigterm @AnshSinghSonkhia @canaleal @Snailedlt @weh @swapnilhpatil
0