update icon: nodejs (plain, plain-wordmark, line, line-wordmark) #2418
Conversation
|
Hi! I'm the Check our CONTRIBUTING guide for more details regarding these errors. Please address these issues. When you update this PR, I will check your SVGs again. Thanks for your help, |
Dear SVG-Checker Bot, I did not even touch that file, and it is exactly sorted as it is in |
|
Please ignore the check bot. We have a PR that should fix it, but for now it is kinda broken :/ |
There was a problem hiding this comment.
Great work @Finii !
Thank you for suggesting and fixing this issue! ❤️
The only thing I would suggest to improve the icons is to move the fill up before the path, so that it is a bit easier to see the diff and maintain it, but it's not a big enough deal to warrant non-approval.
Great work as always! ✅
|
Hi there, I'm Devicons' Peek Bot and I just peeked at the icons that you wanted to add using icomoon.io. Here are the SVGs as intepreted by Icomoon when we upload the files: Here are the zoomed-in screenshots of the added icons as SVGs: Here are the icons that will be generated by Icomoon: Here are the zoomed-in screenshots of the added icons as icons: Here are the colored versions: The maintainers will now check for:
In case of font issues, it might be caused by Icomoon not accepting strokes in the SVGs. Check this doc for more details and fix the issues as instructed by Icomoon and update this PR once you are done. Thank you for contributing to Devicon! I hope that your icons are accepted into the repository. Note: If the images don't show up, it has been autodeleted by Imgur after 6 months due to our API choice. Cheers, |
[why] The plain/line item contains two lines that are not visible in the original icon. Technically they are there but they are hidden. These lines make it impossible to recognize the stylized N that is the basis of the icon. [how] Take the rounded hexagon from the wps file (because it was the most clean one) and hand draw the lines of the N. Create from that simple form all the new plain/line icons. Use a different stroke thickness for the wordmark icons because the previously used line width is ridiculously thin. After optimized export from Inkscape hand-edit file to re-sort elements, remove unused fill attributes and make start identical to previous svgs. Signed-off-by: Fini Jastrow <ulf.fini.jastrow@desy.de>
|
Hi! I'm the Check our CONTRIBUTING guide for more details regarding these errors. Please address these issues. When you update this PR, I will check your SVGs again. Thanks for your help, |
Whatever, that is simple. Just changed the files in an editor and re-used the 'preamble' of the svgs in the repo instead of 'stock inkscape' (see commit message). 👍 |
[why]
The plain/line item contains two lines that are not visible in the original icon. Technically they are there but they are hidden. These lines make it impossible to recognize the stylized N that is the basis of the icon.
[how]
Take the rounded hexagon from the
epsfile (because it was the most clean one) and hand draw the lines of theN. Create from that simple form all the new plain/line icons.Use a different stroke thickness for the wordmark i 8000 cons because the previously used line width is ridiculously thin.
Images
Left: current, right: suggested new form
plain
line
plain wordmark
line wordmark
original for reference
This has been suggested by @Snailedlt here: #2011 (comment)
(Hope I got all the names, branches, and bits and pieces right this time 😬 )