8000 Revert "new icon: delphi (original, plain)" by Snailedlt · Pull Request #2427 · devicons/devicon · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Revert "new icon: delphi (original, plain)" #2427

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 2, 2025

Conversation

Snailedlt
Copy link
Collaborator

Reverts #2290

@Snailedlt Snailedlt merged commit 7369e22 into develop Jun 2, 2025
4 checks passed
@Finii
Copy link
Finii commented Jun 2, 2025

Hmm, nitpick mode on:

The plain icon in this PR is not one-color but two: It has transparent, red, and white.

According to some info it should be transparent and red only?

image

Transparent visualized as checkerboard

@Finii
Copy link
Finii commented Jun 2, 2025

Hmm, in fact it has 3 colors + transparent - in 5 paths:

image

image

There should be only one path: https://github.com/devicons/devicon/blob/master/CONTRIBUTING.md#svg-standards

@Finii
Copy link
Finii commented Jun 2, 2025

Ah this is a revert 🤦‍♀️

Sorry.

@Snailedlt
Copy link
Collaborator Author

Hahah, no worries. I learned it the hard way, I wish you were there to correct me earlier so I didn't have to go through the trouble of inverting it 😅

@canaleal canaleal mentioned this pull request Jun 30, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants
0