8000 new icon: delphi (original, plain) by Snailedlt · Pull Request #2429 · devicons/devicon · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

new icon: delphi (original, plain) #2429

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 15 commits into from
Jun 2, 2025
Merged

new icon: delphi (original, plain) #2429

merged 15 commits into from
Jun 2, 2025

Conversation

Snailedlt
Copy link
Collaborator

re-opening this PR after reverting doesn't work, so I created a new one

Double check these details before you open a PR

  • PR does not match another non-stale PR currently opened
  • PR name matches the format new icon: Icon name (versions separated by comma). More details here
  • PR's base is the develop branch.
  • Your icons are inside a folder as seen here
  • SVG matches the standards laid out here
  • A new object is added in the devicon.json file at the correct alphabetic position as seen here

This PR closes NONE

Link to prove your SVG is correct and up-to-date.

https://www.embarcadero.com/br/news/logo

Bulani and others added 13 commits October 25, 2024 11:42
@Bulani
new icon: delphi-12 (original)
1580eab
@Bulani
new icon: delphi-12 (original)
d2bdcd9
@Bulani
new icon: delphi (original)
70ac3c4
@Bulani
Merge branch 'develop' into new-icon-delphi-12
5917899
@Bulani
Merge branch 'develop' into new-icon-delphi-12
dcdfe51
@Bulani
Add plain icon
90024fd
@Bulani
Merge branch 'new-icon-delphi-12' of https://github.com/Bulani/devicon …
1298150 
…into new-icon-delphi-12
@Bulani
Merge branch 'develop' into new-icon-delphi-12
8000
63e29d4
@Bulani
Merge branch 'develop' into new-icon-delphi-12
9811fc3
@Bulani
Optimizing icons
3c27bbd
@Snailedlt @gewaleelek
Add optimized version created by @gewaleelek
283735c 
Optimized version of the one created by @gewaleelek here: devicons#2290 (comment)

Co-authored-by: gewaleelek <165679471+gewaleelek@users.noreply.github.com>
@Snailedlt
Merge branch 'develop' into new-icon-delphi-12
a3ce0aa
@Snailedlt
Merge pull request #66 from Bulani/new-icon-delphi-12
04b1fee 
New icon delphi 12
@Snailedlt Snailedlt added the feature:icon PR when a new icon is ready to be added to the collection label Jun 2, 2025
@Snailedlt Snailedlt mentioned this pull request Jun 2, 2025
Closed
6 tasks
@github-actions GitHub Actions
Copy link
Contributor
github-actions bot commented Jun 2, 2025

Hi!

I'm the check-bot and we have some issues with your PR:

The PR's base branch is `master`, but should be `develop`
Please change the PR so that it's based on, and merged into `develop`

Check our CONTRIBUTING guide for more details regarding these errors.

Please address these issues. When you update this PR, I will check your SVGs again.

Thanks for your help,
SVG-Checker Bot 😄

@Snailedlt Snailedlt mentioned this pull request Jun 2, 2025
Merged
6 tasks
@Snailedlt Snailedlt changed the base branch from master to develop June 2, 2025 11:59
@github-actions GitHub Actions
Copy link
Contributor
github-actions bot commented Jun 2, 2025

Hi!

I'm the check-bot and we have some issues with your PR:

devicon.json is not sorted correctly.
Please make sure that your icon is added in the `devicon.json` file at the correct alphabetic position
as seen here: https://github.com/devicons/devicon/wiki/Updating-%60devicon.json%60

Check our CONTRIBUTING guide for more details regarding these errors.

Please address these issues. When you update this PR, I will check your SVGs again.

Thanks for your help,
SVG-Checker Bot 😄

@Snailedlt Snailedlt added the bot:peek Trigger peek-bot. Remove and re-add the label to re-trigger label Jun 2, 2025
@github-actions GitHub Actions
Copy link
Contributor
github-actions bot commented Jun 2, 2025

Hi!

I'm the check-bot and we have some issues with your PR:

devicon.json is not sorted correctly.
Please make sure that your icon is added in the `devicon.json` file at the correct alphabetic position
as seen here: https://github.com/devicons/devicon/wiki/Updating-%60devicon.json%60

Check our CONTRIBUTING guide for more details regarding these errors.

Please address these issues. When you update this PR, I will check your SVGs again.

Thanks for your help,
SVG-Checker Bot 😄

@github-actions GitHub Actions
Copy link
Contributor
github-actions bot commented Jun 2, 2025

Hi there,

I'm Devicons' Peek Bot and I just peeked at the icons that you wanted to add using icomoon.io.

Here are the SVGs as intepreted by Icomoon when we upload the files:
Imgur Images

Here are the zoomed-in screenshots of the added icons as SVGs:
Imgur Images

Here are the icons that will be generated by Icomoon:
Imgur Images

Here are the zoomed-in screenshots of the added icons as icons:
Imgur Images

Here are the colored versions:
Imgur Images

The maintainers will now check for:

  1. The number of Glyphs matches the number of SVGs that were selected.
  2. The icons (second group of pictures) look the same as the SVGs (first group of pictures).
  3. The icons are of high quality (legible, matches the official logo, etc.)
  4. A new object is added in the devicon.json file at the correct alphabetic position as seen here

In case of font issues, it might be caused by Icomoon not accepting strokes in the SVGs. Check this doc for more details and fix the issues as instructed by Icomoon and update this PR once you are done.

Thank you for contributing to Devicon! I hope that your icons are accepted into the repository.

Note: If the images don't show up, it has been autodeleted by Imgur after 6 months due to our API choice.

Cheers,
Peek Bot 😊

Snailedlt
Snailedlt commented Jun 2, 2025
View reviewed changes
Copy link
Collaborator Author
@Snailedlt Snailedlt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'll merge this since I've only done minor non-controversial changes since the last approval in the previous PR: #2290

Big thanks again to @Bulani, @gewaleelek and @Finii for your contributions!

Feel free to open a new discussion or PR if you disagree with any of the changes I made after the last review

@Snailedlt Snailedlt merged commit da27377 into devicons:develop Jun 2, 2025
6 checks passed
@canaleal canaleal mentioned this pull request Jun 30, 2025
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
bot:peek Trigger peek-bot. Remove and re-add the label to re-trigger feature:icon PR when a new icon is ready to be added to the collection
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Snailedlt @Bulani
0