8000 Gitlab connector should not require the api scope. · Issue #1347 · dexidp/dex · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Gitlab connector should not require the api scope. #1347

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
gypsydiver opened this issue Nov 19, 2018 · 1 comment
Closed

Gitlab connector should not require the api scope. #1347

gypsydiver opened this issue Nov 19, 2018 · 1 comment
Labels
area/connector help wanted

Comments

@gypsydiver
Copy link
Contributor
gypsydiver commented Nov 19, 2018 •
edited
Loading

As of now, the Gitlab connector requires users to grant the api scope to configured applications in order to retrieve information that could be just as easily pulled using read only scopes (read_user, openid).

The /oauth/userinfo endpoint provides all group information needed.

Can provide PR for this.

Related: #1222
Solves: #1246
@srenatus
Copy link
Contributor

Happy to take a PR there. ❤️ Could you please include some pointer to some current API docs?

@gypsydiver gypsydiver mentioned this issue Nov 20, 2018
Merged
@srenatus srenatus mentioned this issue Nov 27, 2018
Closed
mmrath pushed a commit to mmrath/dex that referenced this issue Sep 2, 2019
@srenatus
Merge pull request dexidp#1351 from CognotektGmbH/gypsydiver/1347-pr-…
cbd9092 
…gitlab-groups

Gitlab connector should not require the api scope.

Fixes dexidp#1347.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
area/connector help wanted
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@srenatus @gypsydiver
0