8000 fix timeout bug for etcd3 client connect by byxorna · Pull Request #1266 · dexidp/dex · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

fix timeout bug for etcd3 client connect #1266

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Sep 10, 2018
Merged

fix timeout bug for etcd3 client connect #1266

merged 1 commit into from
Sep 10, 2018

Conversation

byxorna
Copy link
@byxorna byxorna commented Aug 2, 2018

Heya! Subtle bug here for etcd3 storage backend. The timeout was being unnecessarily multiplied by time.Second causing a near-infinite timeout before returning on connection errors. This makes debugging Dex with etcd storage very annoying :)

fmt.Printf("time 1: %v\n", 2 * time.Second)
fmt.Printf("time 2: %v\n", 2 * time.Second * time.Second)

output:
time 1: 2s
time 2: 555555h33m20s

@byxorna byxorna force-pushed the gabe/fix-etcd-timeout-bug branch from b39d4a4 to 94bd948 Compare August 2, 2018 21:41
@byxorna
Copy link
Author
byxorna commented Aug 9, 2018

Bump! Who should i @mention to get traction on getting this merged? Is there a CLA to sign?

srenatus
srenatus approved these changes Sep 10, 2018
View reviewed changes
Copy link
Contributor
@srenatus srenatus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch! Thank you for your contribution 🎉

@srenatus srenatus merged commit 666356d into dexidp:master Sep 10, 2018
mmrath pushed a commit to mmrath/dex that referenced this pull request Sep 2, 2019
@srenatus
Merge pull request dexidp#1266 from byxorna/gabe/fix-etcd-timeout-bug
d62903d 
fix timeout bug for etcd3 client connect
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@srenatus srenatus srenatus approved these changes

Assignees
No one assigned
Labels
kind/bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@byxorna @srenatus
0