fix default baseURL for GitLab connector #1279
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I notified GitLab about the problem as well but they are not sure what to do about that subdomain: https://gitlab.com/gitlab-com/production/issues/441#note_97442708 |
devonbarrett
approved these changes
Aug 29, 2018
srenatus
approved these changes
Sep 3, 2018
mmrath
pushed a commit
to mmrath/dex
that referenced
this pull request
Sep 2, 2019
fix default baseURL for GitLab connector
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The URL
https://www.gitlab.comwhich is the default baseURL for the GitLab connector does not work any more. According to the DNS entries it's still pointing to an Azure ip adress while the whole service has moved to google cloud. Sincehttps://gitlab.comis main URL for GitLab anyway that's probably a better default anyway.Documentation also updated.