8000 chore: Check block proposal version before integrity by eichhorl · Pull Request #4345 · dfinity/ic · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

chore: Check block proposal version before integrity #4345

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 12, 2025

Conversation

eichhorl
Copy link
Contributor
@eichhorl eichhorl commented Mar 12, 2025

Otherwise we might declare empty block proposals as invalid (instead of simply removing them) after an upgrade, if the data payload layout changed due to the upgrade.

@github-actions github-actions bot added the chore label Mar 12, 2025
@eichhorl eichhorl marked this pull request as ready for review March 12, 2025 16:26
@eichhorl eichhorl requested a review from a team as a code owner March 12, 2025 16:26
Copy link
Contributor
@kpop-dfinity kpop-dfinity left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@eichhorl eichhorl enabled auto-merge March 12, 2025 16:39
@eichhorl eichhorl added this pull request to the merge queue Mar 12, 2025
Merged via the queue into master with commit 5566209 Mar 12, 2025
24 checks passed
@eichhorl eichhorl deleted the eichhorl/check-proposal-version-first branch March 12, 2025 18:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants
0