8000 feat(tables): prioritize ICP in token and neuron lists by yhabib · Pull Request #7004 · dfinity/nns-dapp · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

feat(tables): prioritize ICP in token and neuron lists #7004

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Jun 27, 2025
Merged

feat(tables): prioritize ICP in token and neuron lists #7004

merged 4 commits into from
Jun 27, 2025

Conversation

yhabib
Copy link
Contributor
@yhabib yhabib commented Jun 25, 2025 •
edited
Loading

Motivation

The ICP token and ICP neurons should be displayed at the top of the tokens and staking tables. This second PR applies the new comparators and updates the existing ones to always prioritize ICP.

NNS1-3914

Changes

  • Apply new comparators.
  • Refactor existing ones to prioritize ICP.

Tests

  • Update tests.

Todos

  • Accessibility (a11y) – any impact?
  • Changelog – is it needed?

@yhabib yhabib marked this pull request as ready for review June 25, 2025 12:17
@yhabib yhabib requested a review from a team as a code owner June 25, 2025 12:17
mstrasinskis
mstrasinskis approved these changes Jun 26, 2025
View reviewed changes
Copy link
Contributor
@mstrasinskis mstrasinskis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

Base automatically changed from nns1-3914/sorting to main June 27, 2025 07:33
@yhabib yhabib force-pushed the nns1-3914/apply-new-sorting branch from 8f3eb9d to 7ba0a80 Compare June 27, 2025 07:35
@yhabib yhabib added this pull request to the merge queue Jun 27, 2025
Merged via the queue into main with commit ae558cc Jun 27, 2025
36 checks passed
@yhabib yhabib deleted the nns1-3914/apply-new-sorting branch June 27, 2025 08:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mstrasinskis mstrasinskis mstrasinskis approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@yhabib @mstrasinskis
0