8000 Update Google API version by nyergler · Pull Request #40 · dghubble/gologin · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Update Google API version #40

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Jul 15, 2020
Merged

Update Google API version #40

merged 4 commits into from
Jul 15, 2020

Conversation

nyergler
Copy link
Contributor

The Google API module renamed Userinfoplus to Userinfo; this can
lead to incompatibilties when using gologin with other Google API
packages.

This commit updates the dependency version for the Google API wrapper
and replaces references to Userinfoplus with simply Userinfo.

@nyergler
Update Google API version
9ba2884 
The Google API module renamed Userinfoplus to Userinfo; this can
lead to incompatibilties when using gologin with other Google API
packages.

This commit updates the dependency version for the Google API wrapper
and replaces references to Userinfoplus with simply Userinfo.
@dghubble
Copy link
Owner

Failing tests

@nyergler
Copy link
Contributor Author

Apologies, @dghubble; I've updated the test and it looks like it's passing now.

@dghubble
Copy link
Owner

Google seems to have renamed the Userinfoplus struct to Userinfo between google.golang.org/api v0.21.0 and v0.22.0. Depending on your perspective, its another example of Google APIs ignoring Go module versioning or another example of the "change the import" module policy being too draconian.

So this doesn't affect gologin and ability to login directly. But, as you mention, if you later use those Userinfoplus structs with other libraries expecting Userinfo, there may be incompatibilities. Similarly, updating google.golang.org beyond v0.21.0 could create incompatibilities. Since Google APIs aren't likely to revert, I'm in favor of going forward.

It looks like you tried several versions based on your go.sum. Would you mind resetting go.mod and go.sum, then just running go get google.golang.org/api@v0.22.0? Should produce a smaller set of changes. Otherwise I'll go ahead with that in a few days but wanna give you credit if I can.

@nyergler
Copy link
Contributor Author

I'm not sure how I got go.sum so chock-full-o-versions, but I followed your advice and have things trimmed down.

Thanks for the guidance!

@fsaintjacques
Copy link

I also experience this issue when depending on some cloud.google.com modules.

@dghubble dghubble merged commit c39acb8 into dghubble:master Jul 15, 2020
@dghubble
Copy link
Owner

@nyergler thanks!

dghubble added a commit that referenced this pull request Jul 15, 2020
@dghubble
Rename remaining Userinfoplus references in docs
a9540bb 
* Google API renamed Userinfoplus to Userinfo
* See #40
@dghubble dghubble mentioned this pull request Jul 15, 2020
Merged
@fsaintjacques
Copy link

@dghubble Would it be possible to tag 2.2.1?

rockandbabyyp added a commit to rockandbabyyp/gologin that referenced this pull request Aug 5, 2024
@rockandbabyyp @dghubble
Rename remaining Userinfoplus references in docs
cf75eb4 
* Google API renamed Userinfoplus to Userinfo
* See dghubble/gologin#40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@nyergler @dghubble @fsaintjacques
0