[PATCH] Setting hierarchy parameter in recursive function to None to a… #19
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…void issues with mutable default arguments caching previous key values
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@vdavez The issue in a nutshell (a good gotcha) -- mutable default arguments; perfect explanation is here (https://docs.python-guide.org/writing/gotchas/). In summary, setting the
hierarchyparameter toNoneincontent_tag_hierarchyprevents the function from storing state from previous processed records, which was the issue -- the reason this happened is that the first record in your example was anAWARDand the second record anIDV, which meant new keys existed and with the attribute update call, those new keys were getting created.Also to stay consistent with the XML structure, removed some logic that was truncating certain XML keys. For debugging purposes, this should allow users to quickly determine where certain values came from when referencing the XML.