8000 [MINOR] Pagination Support + provide mechanism to override fields.json validations by dherincx92 · Pull Request #20 · dherincx92/fpds · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

[MINOR] Pagination Support + provide mechanism to override fields.json validations #20

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 20 commits into from
Aug 22, 2024
Merged

[MINOR] Pagination Support + provide mechanism to override fields.json validations #20

merged 20 commits into from
Aug 22, 2024

Conversation

dherincx92
Copy link
Owner
@dherincx92 dherincx92 commented Jul 7, 2024 •
edited
Loading
  • Supports pagination for a single FPDS request
  • PENDING: need to add exception handling / empty records for invalid page #

@mitchbregs tagging you since we had discussed some things here. Added a page_count property that should allow us to determine if prev and next have valid values.

@dherincx92 dherincx92 requested a review from mitchbregs July 13, 2024 10:19
@dherincx92 dherincx92 changed the title [MINOR] Pagination Support [MINOR] Pagination Support + provide mechanism to override fields.json validations Aug 22, 2024
@dherincx92
Copy link
Owner Author

@leonkozlowski legend for the approval 💯

mitchbregs
mitchbregs approved these changes Aug 22, 2024
View reviewed changes
Copy link
Collaborator
@mitchbregs mitchbregs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🔥

@dherincx92 dherincx92 merged commit 32336c0 into master Aug 22, 2024
1 check passed
@dherincx92 dherincx92 deleted the minor/pagination-support branch August 22, 2024 03:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mitchbregs mitchbregs mitchbregs approved these changes

@leonkozlowski leonkozlowski leonkozlowski approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@dherincx92 @mitchbregs @leonkozlowski
0