Fix: Improved compliance to the XDG Base Directory Specification #46 #47
+84
−72
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Actually, I left track download fragment files in the cache, but I think I forgot to create the parent directory first. Let me fix that before merging. |
|
Fixed that. Oh yeah, and this should close #46. |
|
Yeah this looks good to me :) I like the part file in cache. It runs fine on my machines too. I'll merge this into a dev branch for now. Thank you for the work! And uh sorry for losing your downloads haha |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This should move everything from
$XDG_CACHE_HOMEinto$XDG_DATA_HOME. I'm not experienced with Rust, so I'm not confident the actual migration code is implemented properly; I tried to check the cases of no database, database in cache, and database in data, and they seemed to work, but do make sure that works.