install build in target environment #30
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull Request Overview
This PR addresses issue #29 by ensuring that missing build dependencies are correctly installed in the target environment. Key changes include:
- Removal of the unused sys import in dependencies.py.
- Addition of a custom MissingDependencyError exception and improved error handling in check_dependencies().
- Introduction of a retry loop in build.py to ensure that build system requirements are installed before proceeding.
Reviewed Changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| conda_pupa/dependencies.py | Introduced MissingDependencyError and refined exception handling for dependency checks. |
| conda_pupa/build.py | Added a retry loop to recheck dependencies and automatically install missing ones. |
Comments suppressed due to low confidence (2)
conda_pupa/dependencies.py:49
- The condition checking for the 'ModuleNotFound' substring in e.stderr might be brittle if the error message format changes. Consider using a more specific error identifier or a robust parsing mechanism to reliably detect the missing dependency.
if ("ModuleNotFound" in e.stderr
conda_pupa/build.py:112
- [nitpick] The retry loop does not log retry attempts, which could make troubleshooting dependency installation issues more challenging. Consider adding logging statements to indicate the retry progress and outcomes.
except dependencies.MissingDependencyError as e:
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #29