8000 [hellfire] SaveGame/LoadGame bin exact + smith enums by qndel · Pull Request #1723 · diasurgical/devilution · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

[hellfire] SaveGame/LoadGame bin exact + smith enums #1723

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Sep 25, 2019

Conversation

qndel
Copy link
Member
@qndel qndel commented Sep 25, 2019

enums changes should be merged with master

@qndel qndel added Binary exact code cleanup Cosmetic enhancement to the code to make it look nicer. hellfire labels Sep 25, 2019
@AJenbo AJenbo mentioned this pull request Sep 25, 2019
32 tasks
@AJenbo AJenbo merged commit 152573b into diasurgical:hellfire Sep 25, 2019
@AJenbo
Copy link
Member
AJenbo commented Sep 25, 2019

Nice work :)

@AJenbo AJenbo deleted the SaveGame branch September 25, 2019 09:41
@qndel
Copy link
Member Author
qndel commented Sep 25, 2019

this also fixes some functions where asm appeared bin exact but the addresses were wrong because of wrong numbers :P

@AJenbo
Copy link
Member
AJenbo commented Sep 25, 2019

Nice, and really nice that the saveload code is now bin exact.

@qndel
Copy link
Member Author
qndel commented Sep 25, 2019

I've been wanting to do these enums for a long time xD will add witch/healer when we clean their functions

@AJenbo AJenbo mentioned this pull request Sep 25, 2019
95 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Binary exact code cleanup Cosmetic enhancement to the code to make it look nicer. hellfire
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants
0