8000 :bug: Fix runtime warning by ff137 · Pull Request #7 · didx-xyz/acapy · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

🐛 Fix runtime warning #7

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 79 commits into
base: development
Choose a base branch
from
Open

Conversation

ff137
Copy link
Collaborator
@ff137 ff137 commented Nov 27, 2024

also has to drop did:tdw support, since their dependencies overrides our askar fork dependency (which loses order_by support).

Currently includes log changes - to be branched out to different PR

ff137 and others added 30 commits November 14, 2024 10:30
* ✨ add `order_by` and `descending` options to query / scan and fetch_all methods

Signed-off-by: ff137 <ff137@proton.me>

* ✨ add `order_by` and `descending` options to PaginatedQuerySchema

Signed-off-by: ff137 <ff137@proton.me>

* ✨ modify `get_limit_offset` to `get_paginated_query_params`

Signed-off-by: ff137 <ff137@proton.me>

* ✨ add ordering to InMemoryStorage scan and fetch_all methods

Signed-off-by: ff137 <ff137@proton.me>

* 🚧 test in-progress aries-askar PR: openwallet-foundation/askar#291

Signed-off-by: ff137 <ff137@proton.me>

* ⬆️ Update lock file

Signed-off-by: ff137 <ff137@proton.me>

* 🎨 fix ruff warning

Signed-off-by: ff137 <ff137@proton.me>

* ✅ fix assertions

Signed-off-by: ff137 <ff137@proton.me>

* 🚧 test aries-askar with TestPyPI package

Signed-off-by: ff137 <ff137@proton.me>

* 🚧 test latest askar testpypi package

Signed-off-by: ff137 <ff137@proton.me>

* 🎨 Update order_by description and default value. Include in schema

Signed-off-by: ff137 <ff137@proton.me>

* ⬆️ Update aries-askar test pypi package to pre-orjson feat release

Signed-off-by: ff137 <ff137@proton.me>

---------

Signed-off-by: ff137 <ff137@proton.me>
…nt by logging statements

Signed-off-by: Ricky Ng-Adam <ricky.ng-adam-ext@mcn.gouv.qc.ca>
Signed-off-by: ff137 <ff137@proton.me>
* 👷 Upload Python Package to TestPyPI

Signed-off-by: ff137 <ff137@proton.me>

* 👷 Update project name and version for testpypi

Signed-off-by: ff137 <ff137@proton.me>

* 🎨

Signed-off-by: ff137 <ff137@proton.me>

---------

Signed-off-by: ff137 <ff137@proton.me>
* Rebase the pagination with ordering feature on latest release (#2)

* ✨ add `order_by` and `descending` options to query / scan and fetch_all methods

Signed-off-by: ff137 <ff137@proton.me>

* ✨ add `order_by` and `descending` options to PaginatedQuerySchema

Signed-off-by: ff137 <ff137@proton.me>

* ✨ modify `get_limit_offset` to `get_paginated_query_params`

Signed-off-by: ff137 <ff137@proton.me>

* ✨ add ordering to InMemoryStorage scan and fetch_all methods

Signed-off-by: ff137 <ff137@proton.me>

* 🚧 test in-progress aries-askar PR: openwallet-foundation/askar#291

Signed-off-by: ff137 <ff137@proton.me>

* ⬆️ Update lock file

Signed-off-by: ff137 <ff137@proton.me>

* 🎨 fix ruff warning

Signed-off-by: ff137 <ff137@proton.me>

* ✅ fix assertions

Signed-off-by: ff137 <ff137@proton.me>

* 🚧 test aries-askar with TestPyPI package

Signed-off-by: ff137 <ff137@proton.me>

* 🚧 test latest askar testpypi package

Signed-off-by: ff137 <ff137@proton.me>

* 🎨 Update order_by description and default value. Include in schema

Signed-off-by: ff137 <ff137@proton.me>

* 🐛 fix deserialisation of descending: bool parameter

Signed-off-by: ff137 <ff137@proton.me>

* ⏪ revert to testing 0.3.3b0 askar test package

Signed-off-by: ff137 <ff137@proton.me>

* 🔥 remove unnecessary record sorts (now that askar sorts by id == sorting by created_at)

Signed-off-by: ff137 <ff137@proton.me>

* ✅ fix test assertions -- wallet_list and connections_list no longer does additional sorting

Signed-off-by: ff137 <ff137@proton.me>

* ⬆️ Update lock file

Signed-off-by: ff137 <ff137@proton.me>

---------

Signed-off-by: ff137 <ff137@proton.me>

* arrow_up: Upgrade python-dateutil

Resolves calling deprecated `datetime.utcfromtimestamp` method

Signed-off-by: ff137 <ff137@proton.me>

* art: Rename class to resolve PytestCollectionWarning

Signed-off-by: ff137 <ff137@proton.me>

* art: Replace deprecated `open_binary` method with `files`

Signed-off-by: ff137 <ff137@proton.me>

* art: Replace deprecated `scope` keyword with `loop_scope`

Signed-off-by: ff137 <ff137@proton.me>

* art: Filter Aries RFC 0160 DeprecationWarning in tests

Signed-off-by: ff137 <ff137@proton.me>

* art: Filter Pydantic UserWarning in test

Signed-off-by: ff137 <ff137@proton.me>

* arrow_up: Upgrade aiohttp to latest release and update lock file

Signed-off-by: ff137 <ff137@proton.me>

* art: Remove unnecessary asyncio pytest markers

Resolves unclosed event loop warnings.

Signed-off-by: ff137 <ff137@proton.me>

---------

Signed-off-by: ff137 <ff137@proton.me>
Signed-off-by: ff137 <ff137@proton.me>
* art: Modify count/start query params to be Integers, not Strings

Signed-off-by: ff137 <ff137@proton.me>

* memo: Update openapi spec

Signed-off-by: ff137 <ff137@proton.me>

* rewind: Revert start/count field to remain String type; mark as deprecated

Signed-off-by: ff137 <ff137@proton.me>

* sparkles: Implement limit/offset alongside deprecated count/start

Signed-off-by: ff137 <ff137@proton.me>

* art: Standardise naming convention from count/start to limit/offset

Signed-off-by: ff137 <ff137@proton.me>

* rewind: Revert start/count field to remain String type; mark as deprecated

Signed-off-by: ff137 <ff137@proton.me>

* sparkles: Implement limit/offset alongside deprecated count/start

Signed-off-by: ff137 <ff137@proton.me>

* art: Remove unused query string schema from `w3c_creds_list`

Signed-off-by: ff137 <ff137@proton.me>

* art: Rename args

Signed-off-by: ff137 <ff137@proton.me>

* memo: Update openapi specs

Signed-off-by: ff137 <ff137@proton.me>

* white_check_mark:

Signed-off-by: ff137 <ff137@proton.me>

---------

Signed-off-by: ff137 <ff137@proton.me>
Signed-off-by: ff137 <ff137@proton.me>
Signed-off-by: ff137 <ff137@proton.me>
Signed-off-by: ff137 <ff137@proton.me>
Signed-off-by: ff137 <ff137@proton.me>
Signed-off-by: ff137 <ff137@proton.me>
Signed-off-by: ff137 <ff137@proton.me>
Signed-off-by: ff137 <ff137@proton.me>
Signed-off-by: ff137 <ff137@proton.me>
Signed-off-by: ff137 <ff137@proton.me>
Signed-off-by: ff137 <ff137@proton.me>
Signed-off-by: ff137 <ff137@proton.me>
Signed-off-by: ff137 <ff137@proton.me>
Signed-off-by: ff137 <ff137@proton.me>
Signed-off-by: ff137 <ff137@proton.me>
Signed-off-by: ff137 <ff137@proton.me>
Signed-off-by: ff137 <ff137@proton.me>
This reverts commit 2f6526d.

Signed-off-by: ff137 <ff137@proton.me>
Signed-off-by: ff137 <ff137@proton.me>
Signed-off-by: ff137 <ff137@proton.me>
ff137 and others added 22 commits November 26, 2024 13:17
Signed-off-by: ff137 <ff137@proton.me>
Signed-off-by: ff137 <ff137@proton.me>
Signed-off-by: ff137 <ff137@proton.me>
…pypi package)

Signed-off-by: ff137 <ff137@proton.me>
Signed-off-by: ff137 <ff137@proton.me>
Signed-off-by: ff137 <ff137@proton.me>
Signed-off-by: ff137 <ff137@proton.me>
Signed-off-by: ff137 <ff137@proton.me>
Signed-off-by: ff137 <ff137@proton.me>
Signed-off-by: ff137 <ff137@proton.me>
Signed-off-by: ff137 <ff137@proton.me>
…ation#3358)

* ⬆️ Upgrade ruff version in pre-commit config and lint workflow

Signed-off-by: ff137 <ff137@proton.me>

* 🎨 Apply ruff formatting

Signed-off-by: ff137 <ff137@proton.me>

* ⬆️ Upgrade pre-commit hook version

Signed-off-by: ff137 <ff137@proton.me>

---------

Signed-off-by: ff137 <ff137@proton.me>
Signed-off-by: ff137 <ff137@proton.me>
Co-authored-by: jamshale <31809382+jamshale@users.noreply.github.com>
Signed-off-by: ff137 <ff137@proton.me>
Signed-off-by: ff137 <ff137@proton.me>
Signed-off-by: ff137 <ff137@proton.me>
Resolves openwallet-foundation#3360

Signed-off-by: ff137 <ff137@proton.me>
Signed-off-by: ff137 <ff137@proton.me>
@ff137 ff137 force-pushed the test-fix-runtime-warning branch from 4d41633 to e7ba26f Compare November 28, 2024 11:27
@ff137 ff137 force-pushed the test-fix-runtime-warning branch from 7ee124b to 3a28f5a Compare November 28, 2024 13:23
Signed-off-by: ff137 <ff137@proton.me>
@ff137 ff137 force-pushed the development branch 3 times, most recently from 4568cad to 877ac50 Compare May 5, 2025 10:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants
0