10000 fix test failure on compare lines ending with "\r\n" and "\n" (#132)_57 by satyamacn · Pull Request #340 · diem/move · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

fix test failure on compare lines ending with "\r\n" and "\n" (#132)_57 #340

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jan 16, 2023
Merged

fix test failure on compare lines ending with "\r\n" and "\n" (#132)_57 #340

merged 1 commit into from
Jan 16, 2023

Conversation

satyamacn
Copy link
Contributor
@satyamacn satyamacn commented Jan 13, 2023 •
edited
Loading

Motivation

  • fix test failure on compare lines ending with "\r\n" and "\n"

Test Plan

  • Cargo test

@satyamacn
Copy link
Contributor Author

/canary

bors-diem pushed a commit that referenced this pull request Jan 13, 2023
@jiangying000 @bors-diem
fix test failure on compare lines ending with "\r\n" and "\n" (#132)
501bf4b 
* [fix] fix test failure on "crlf"

starcoinorg/starcoin#3401

* restore M.move symlink

Signed-off-by: satyamacn <satyam.arya@accenture.com>
Closes: #340
@bors-diem
Copy link

☀️ Canary successful

@satyamacn satyamacn changed the title fix test failure on compare lines ending with "\r\n" and "\n" (#132) fix test failure on compare lines ending with "\r\n" and "\n" (#132)_57 Jan 13, 2023
dhaneshacn
dhaneshacn previously approved these changes Jan 16, 2023
View reviewed changes
@sahithiacn
Copy link
Contributor

/land

@jiangying000 @bors-diem
fix test failure on compare lines ending with "\r\n" and "\n" (diem#132)
877a9b7 
* [fix] fix test failure on "crlf"

starcoinorg/starcoin#3401

* restore M.move symlink

Signed-off-by: satyamacn <satyam.arya@accenture.com>
Closes: diem#340
@bors-diem bors-diem closed this in 877a9b7 Jan 16, 2023
@bors-diem bors-diem merged commit 877a9b7 into diem:main Jan 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dhaneshacn dhaneshacn dhaneshacn left review comments

@KoushikGavini KoushikGavini Awaiting requested review from KoushikGavini

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@satyamacn @bors-diem @sahithiacn @dhaneshacn @jiangying000
0