8000 chore: add test res.socket by nigrosimone · Pull Request #163 · dimdenGD/ultimate-express · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content
chore: add test res.socket #163
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Apr 30, 2025
Merged

chore: add test res.socket #163

merged 1 commit into from
Apr 30, 2025

Conversation

nigrosimone
Copy link
Contributor
@nigrosimone nigrosimone commented Apr 30, 2025 •
edited
Loading

Original test is

app.get('/test', (req, res) => {
    console.log(res.socket.writable); // expected true
    res.end();
    console.log(res.socket.writable); // expected false
});

it works on ultimate-express (true false), on express is: true true

this test just check socket property is defined.

I don't know if the correct behaviour is true true (express)

@dimdenGD dimdenGD merged commit fe49abb into dimdenGD:main Apr 30, 2025
5 checks passed
@nigrosimone nigrosimone deleted the test-socket branch April 30, 2025 18:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@nigrosimone @dimdenGD
0