Support skipping extensions & filtering in pgcopydb dump/restore cli #572 8000
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
13d80b3 to
5b34c96
Compare
|
Please rebase to the current main branch, now that the SQLite catalogs are merged you will see some impact in how to handle this. It might be that we don't need this PR anymore, but I'm not sure. The main difference is that we have an on-disk cache of the catalogs now. |
dimitri
reviewed
Dec 18, 2023
src/bin/pgcopydb/cli_dump.c
Outdated
| @@ -370,7 +380,7 @@ cli_dump_schema_section(CopyDBOptions *dumpDBoptions, | |||
| exit(EXIT_CODE_INTERNAL_ERROR); | |||
| } | |||
|
|
|||
| if (!copydb_init_specs(©Specs, dumpDBoptions, DATA_SECTION_NONE)) | |||
| if (!copydb_init_specs(©Specs, dumpDBoptions, DATA_SECTION_ALL)) | |||
There was a problem hiding this comment.
I'm not sure that we need DATA_SECTION_ALL here, but thinking about it, we might. After all we want to be able to implement the whole filtering.
dimitri
previously approved these changes
Dec 18, 2023
Currently, pgcopydb dump & restore doesn't support skipping extensions or filtering because we don't populate the context with extension details & skip list information. Signed-off-by: Arunprasad Rajkumar <ar.arunprasad@gmail.com>
5b34c96 to
fb38825
Compare
fb38825 to
de1423f
Compare
dimitri
approved these changes
Dec 19, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, pgcopydb dump & restore doesn't support skipping extensions or filtering because we don't populate the context with extension details & skip list information.