Review the splitLines() API to avoid allocating zero bytes. #6 8000 38
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Make it systematic to first count the lines and then allocate the right amount of memory for the array of pointers to the start of each line, and make sure we don't try and allocate a zero-size array, which can lead to "corrupted size vs. prev_size" errors at run-time.
f0215dc to
43cf472
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Make it systematic to first count the lines and then allocate the right amount of memory for the array of pointers to the start of each line, and make sure we don't try and allocate a zero-size array, which can lead to "corrupted size vs. prev_size" errors at run-time.
See #609