WIP: Implement support for copying roles. #64
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
8000
Postgres roles are global objects, which means they do not belong to any specific database in an instance. To be able to dump and restore the roles, we need to use pg_dumpall --roles-only.
This allows to implement "create role if not exists" our own way, accepting roles that already exists as they are.
In testing it's nice to use ROLLBACK to try again and again... not in the code we want to ship.
We now create a "pagila" role and make it owner of the database and its objects, and then run the pgcopydb commands using that new non-superuser role. The creation of the new role on the target system is made by calling into pgcopydb dump roles and pgcopydb restore roles.
This includes a STEP 0 that copies the roles from the source instance to the target instance.
hanefi
pushed a commit
to hanefi/pgcopydb
that referenced
this pull request
Feb 21, 2025
…Variable warnings (dimitri#64) * Fix cppcheck variableScope, shadowArgument, shadowFunction and shadowVariable warnings
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Postgres roles are global objects, which means they do not belong to any
specific database in an instance. To be able to dump and restore the roles,
we need to use pg_dumpall --roles-only.
Fixed #49.