8000 Fix database name identifier in ALTER DATABASE properties using PQescapeIdentifier. by VaibhaveS · Pull Request #645 · dimitri/pgcopydb · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Fix database nam 8000 e identifier in ALTER DATABASE properties using PQescapeIdentifier. #645

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Jan 23, 2024
Merged

Fix database name identifier in ALTER DATABASE properties using PQescapeIdentifier. #645

merged 4 commits into from
Jan 23, 2024

Conversation

VaibhaveS
Copy link
Contributor

Logs

2024-01-18 14:10:58 53 ERROR  pgsql.c:1978              [TARGET 1664] ERROR:  syntax error at or near "-"
2024-01-18 14:10:58 53 ERROR  pgsql.c:1989              [TARGET 1664] SQL query: ALTER DATABASE vaibhave-test SET "search_path" TO '$user', 'public';

@VaibhaveS VaibhaveS force-pushed the fix-alterdb-identifier branch from 22d2249 to 3565086 Compare January 19, 2024 14:28
dimitri
dimitri previously approved these changes Jan 22, 2024
View reviewed changes
@VaibhaveS VaibhaveS force-pushed the fix-alterdb-identifier branch from 2df3765 to 8ba2f5f Compare January 23, 2024 10:56
@VaibhaveS VaibhaveS requested a review from dimitri January 23, 2024 10:59
dimitri
dimitri requested changes Jan 23, 2024
View reviewed changes
@VaibhaveS VaibhaveS requested a review from dimitri January 23, 2024 12:35
@VaibhaveS
Copy link
Contributor Author

Looks like the filtering is failing randomly.

@dimitri dimitri merged commit 6caad8e into dimitri:main Jan 23, 2024
@dimitri
Copy link
Owner
dimitri commented Jan 23, 2024

Looks like the filtering is failing randomly.

That's the SQLite PRAGMA journal_mode = WAL failed: database is locked problem that we need to look into separately, unrelated to your changes.

@VaibhaveS VaibhaveS deleted the fix-alterdb-identifier branch January 23, 2024 15:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dimitri dimitri dimitri approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@VaibhaveS @dimitri
0