[sqlite] Set PRAGMA only once for catalogs. #651
8000
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I observed frequent `[SQLite] PRAGMA journal_mode = WAL` when it should be run only once as it's a sqlite database property, not something that has be set for every connection. This might fix https://github.com/dimitri/pgcopydb/actions/runs/7614380466/job/20736769276?pr=647 ``` 2024-01-22 16:45:01.923 44 ERROR catalog.c:7129 [SQLite]: PRAGMA journal_mode = WAL failed: database is locked ```
4a5c0ed to
fa26836
Compare
dimitri
approved these changes
Jan 25, 2024
gokhangulbiz
pushed a commit
to gokhangulbiz/pgcopydb
that referenced
this pull request
Jan 26, 2024
I observed frequent `[SQLite] PRAGMA journal_mode = WAL` when it should be run only once as it's a sqlite database property, not something that has be set for every connection. This might fix https://github.com/dimitri/pgcopydb/actions/runs/7614380466/job/20736769276?pr=647 ``` 2024-01-22 16:45:01.923 44 ERROR catalog.c:7129 [SQLite]: PRAGMA journal_mode = WAL failed: database is locked ```
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back lat
2A63
er.
I observed frequent
[SQLite] PRAGMA journal_mode = WALwhen it should be run only once as it's a sqlite database property, not something that has be set for every connection. This might fixhttps://github.com/dimitri/pgcopydb/actions/runs/7614380466/job/20736769276?pr=647