Escape column names while transforming for wal2json plugin. #663
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
71a5693 to
3eb84c2
Compare
dimitri
approved these changes
Feb 2, 2024
arajkumar
added a commit
to arajkumar/pgcopydb
that referenced
this pull request
May 8, 2024
Previously, identifiers coming from the wal2json plugin weren't escaped, and we applied escaping to them while transforming to SQL. However, we recently added proper escaping for all identifiers coming from wal2json [1] using PQescapeIdentifier, which obsoletes the need for escaping in ld_transform.c. [1] dimitri#663 Signed-off-by: Arunprasad Rajkumar <ar.arunprasad@gmail.com>
dimitri
pushed a commit
that referenced
this pull request
May 13, 2024
* Remove redundant identifier escaping from transform Previously, identifiers coming from the wal2json plugin weren't escaped, and we applied escaping to them while transforming to SQL. However, we recently added proper escaping for all identifiers coming from wal2json [1] using PQescapeIdentifier, which obsoletes the need for escaping in ld_transform.c. [1] #663 Signed-off-by: Arunprasad Rajkumar <ar.arunprasad@gmail.com> * Fix tests which always expects quotes on all identifiers Signed-off-by: Arunprasad Rajkumar <ar.arunprasad@gmail.com> --------- Signed-off-by: Arunprasad Rajkumar <ar.arunprasad@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow up of #595