Fix ordering of CFLAGS for sqlite #680
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The CFLAGS for sqlite were being overridden by the default CFLAGS, which caused a portion of the sqlite CFLAGS to be ignored. This commit fixes the ordering of the CFLAGS so that the sqlite CFLAGS are applied after the default CFLAGS. Particularly, we need to apply the -Wno-implicit-fallthrough flag to sqlite, as it generates a lot of warnings with the default CFLAGS on many systems that use -Wimplicit-fallthrough=3.
dimitri
approved these changes
Feb 21, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The CFLAGS for sqlite were being overridden by the default CFLAGS, which caused a portion of the sqlite CFLAGS to be ignored. This commit fixes the ordering of the CFLAGS so that the sqlite CFLAGS are applied after the default CFLAGS.
Particularly, we need to apply the -Wno-implicit-fallthrough flag to sqlite, as it generates a lot of warnings with the default CFLAGS on many systems that use -Wimplicit-fallthrough=3.