Problem: Resume after interrupted clone always fails #698
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We always call `summary_start_timing` regardless of whether the section has been already done or not., which causing insertion(insert or replace) of default value to `done_time_epoch` because `summary_start_timing` won't be called for already done section. Solution: Check whether the section is already completed using `runState` and exit early without calling `summary_start_timing` for already done section. Related to dimitri#692 Signed-off-by: Arunprasad Rajkumar <ar.arunprasad@gmail.com>
dimitri
reviewed
Mar 11, 2024
| "insert into summary(pid, tableoid, partnum, start_time_epoch, command)" | ||
| "insert or replace into summary(pid, tableoid, partnum, start_time_epoch, command)" |
There was a problem hiding this comment.
I'm wondering if that could case issues wrt hiding errors.
dimitri
approved these changes
Mar 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We use
done_time_epochfromtimingsto populaterunState, which helps to skip already processed table sections.However, we call
summary_start_timingregardless of whether the section has been already done or not., which causing insertion(insert or replace) of default value todone_time_epochbecausesummary_start_timingwon't be called for already done section.Without this fix, while resuming after the interruption pgcopydb would do pre-data restore again leading to table already exists error.
Solution: Check whether the section is already completed using
runStateand exit early without callingsummary_start_timingfor already done section.Related to #692