8000 Fixes #813: Error when copying indexes by rimbi · Pull Request #827 · dimitri/pgcopydb · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Fixes #813: Error when copying indexes #827

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jun 28, 2024
Merged

Fixes #813: Error when copying indexes #827

merged 2 commits into from
Jun 28, 2024

Conversation

rimbi
Copy link
Contributor
@rimbi rimbi commented Jun 27, 2024

Create a vacuum queue when copying the indexes section too.

@rimbi rimbi linked an issue Jun 27, 2024 that may be closed by this pull request
Error when copying indexes #813
Closed
@rimbi rimbi requested review from dimitri and hanefi June 27, 2024 09:21
hanefi
hanefi reviewed Jun 27, 2024
View reviewed changes
Copy link
Contributor
@hanefi hanefi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we add a regression test? I believe we have a short list of commands for reproduction in the issue already.

@rimbi
Copy link
Contributor Author
rimbi commented Jun 28, 2024 •
edited
Loading

Can we add a regression test? I believe we have a short list of commands for reproduction in the issue already.

Good point @hanefi! This case is already covered by the pagila-multi-steps test case (as you pinted out). The reason it did not catch the problem was that the queues were initialised with id 0, which is a valid value. A new change initialises them with -1.

@dimitri dimitri merged commit 76828fc into main Jun 28, 2024
19 checks passed
@dimitri dimitri deleted the 813-error-when-copying-indexes branch June 28, 2024 15:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dimitri dimitri dimitri approved these changes

@hanefi hanefi hanefi approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Error when copying indexes
3 participants
@rimbi @dimitri @hanefi
0