Fix out-of-memory issue in creating our pg_restore list file. #831
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Instead of creating the whole contents of the file in-memory, write it to disk one line at a time, keeping only that line in-memory during the whole operation. Also arrange to code to only read the pg_restore --list output one line at a time, no 8000 context is needed to be able to parse this file format (pg_dump archive Table Of Contents).
hanefi
reviewed
Jul 2, 2024
Comment on lines
+61
to
+63
| bool file_iter_lines(const char *filename, size_t bufsize, | ||
| void *context, | ||
| FileIterLinesFun *callback); |
There was a problem hiding this comment.
Why do we have a function declaration and definition if it is not used anywhere in the codebase?
There was a problem hiding this comment.
The idea is that we have other places where we read a file line-by-line that could benefit from this iterator and one-line-at-a-time in memory approach. Also to implement the full iterator protocol, even though the composition with the archive iterator needs to be “open-coded” at the moment, using the lower-level API directly.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Instead of creating the whole contents of the file in-memory, write it to disk one line at a time, keeping only that line in-memory during the whole operation.
Also arrange to code to only read the pg_restore --list output one line at a time, no context is needed to be able to parse this file format (pg_dump archive Table Of Contents).
Fixes #811
Replaces and closes #818