Remove redundant NULL pointer checks #853
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hanefi
reviewed
Jul 23, 2024
Comment on lines
-1682
to
-1687
| if (ptr == NULL) | ||
| { | ||
| log_error("Failed to tokenize Archive Item line: %s", line); | ||
| return false; | ||
| } | ||
|
|
There was a problem hiding this comment.
I'd be happier if you briefly shared why you wanted to remove this check here.
If we keep this check here, we'd have guarantees that there are some more characters after the token that we parsed. I do not really see why we need this check, but I am unsure if it makes sense to remove these lines here.
There was a problem hiding this comment.
I see. The reason is that there is no way for ptr to be NULL. If it is NULL, then it means that line is also NULL, which means that the preceding isdigit(*line) ends with an error. Once ptr is not NULL, then it can't become NULL by incrementing it with ptr++.
hanefi
approved these changes
Jul 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a
cppcheckfinding.