Implement --debug and --trace, adding to --verbose. #97
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Some users are confused by the Unix way of using -vvv to mean “very, very verbose” and accumulate verbosity that way. Introduce --debug as a synonym to -vv and --trace as a synonym to -vvv. The only drawback to also implement --debug and --trace when we could use --verbose several times is to use yet another short option letter. It seems to be worth it given the user feedback though. Also introduce a new log level NOTICE between INFO (default verbosity) and DEBUG (extra verbosity) so that we have a new verbose setting that makes sense. The log_notice() macro isn't used much as yet, following patches and PRs will introduce more usage for it.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some users are confused by the Unix way of using -vvv to mean “very, very verbose” and accumulate verbosity that way. Introduce --debug as a synonym to -vv and --trace as a synonym to -vvv.
The only drawback to also implement --debug and --trace when we could use --verbose several times is to use yet another short option letter. It seems to be worth it given the user feedback though.
Also introduce a new log level NOTICE between INFO (default verbosity) and DEBUG (extra verbosity) so that we have a new verbose setting that makes sense. The log_notice() macro isn't used much as yet, following patches and PRs will introduce more usage for it.