Bug fixes for the transform process. #114
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- make sure to reset the FILE * pointer to NULL after closing the file. - use a stable sub-process to transform JSON files into SQL. For the second point, we re-use the queuing infrastructure introduced in a recent patch. This allows to have a single sub-process started that will handle all the JSON to SQL transformations during replay.
arajkumar
added a commit
to arajkumar/pgcopydb
that referenced
this pull request
Jun 26, 2024
The logic which removes redundant SET for columns who's value is same as in WHERE clause accesses oldValue using newValue index. Both can have varying size items causing out of bound access. We use the correct index to access the old column name, but incorrect index has been used to access the old column value. Solution: Use old column index to access it's value Upstream PR: dimitri#809 Signed-off-by: Arunprasad Rajkumar <ar.arunprasad@gmail.com>
arajkumar
added a commit
to arajkumar/pgcopydb
that referenced
this pull request
Jun 26, 2024
efce882 Problem: Array out of bounds access during transform (dimitri#114) b772480 test: jobs migration created by another user ab53bb8 Problem: double analyze performed on hypertable chunks (dimitri#113) f483439 test: migration of case sensitive objects 98274d3 (chore) Refactor live-migration teardown (dimitri#111) Signed-off-by: Arunprasad Rajkumar <ar.arunprasad@gmail.com>
hanefi
pushed a commit
to hanefi/pgcopydb
that referenced
this pull request
Feb 21, 2025
…imitri#114) * Move `parse_version_number` to Rust and add unit tests
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For the second point, we re-use the queuing infrastructure introduced in a recent patch. This allows to have a single sub-process started that will handle all the JSON to SQL transformations during replay.