Implement --skip-collations. #160
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In case when the target database does not have the same collation provider as the source database, or just different collation names, then a mapping needs to be done before using pgcopydb. Then this option is useful for skipping the pg_restore steps that re-install the source collations.
Closed
arajkumar
added a commit
to arajkumar/pgcopydb
that referenced
this pull request
Sep 18, 2024
Currently, we expect setting REPLICA IDENTITY FULL on CAGGs to succeed. While this works most of the time, it fails when CAGGs have compression enabled. This commit introduces a warning and allows the process to continue even if setting REPLICA IDENTITY FULL fails. Fixes https://linear.app/timescale/issue/DAT-59 Reported by timescale/Support-Dev-Collab#2029 --------- Signed-off-by: Arunprasad Rajkumar <ar.arunprasad@gmail.com> Co-authored-by: James Guthrie <JamesGuthrie@users.noreply.github.com>
arajkumar
added a commit
to arajkumar/pgcopydb
that referenced
this pull request
Sep 18, 2024
11b22dc Fix deadlock during pipeline sync (dimitri#161) fe677b3 Warn and Skip Setting REPLICA IDENTITY FULL on CAGGs (dimitri#160) 85369e3 Improve error propagation via telemetry (dimitri#159) 1784ff6 Fix “Argument list too long” error when using psql (dimitri#158) 4969f80 Retain logs directory for debugging purposes (dimitri#157) fdbdbbc Add rds_tools into extension skip list (dimitri#156) Signed-off-by: Arunprasad Rajkumar <ar.arunprasad@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In case when the target database does not have the same collation provider as the source database, or just different collation names, then a mapping needs to be done before using pgcopydb. Then this option is useful for skipping the pg_restore steps that re-install the source collations.
Fixes #157.